Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: chrome/browser/media/router/discovery/dial/dial_registry.h

Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl (Closed)
Patch Set: resolve code review comments from Mark Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/discovery/dial/dial_registry.h
diff --git a/chrome/browser/media/router/discovery/dial/dial_registry.h b/chrome/browser/media/router/discovery/dial/dial_registry.h
index 93afe5418c9243ce5f4d8eb8ec7232b7b4f4f14a..8b7c7083b25af213f2d68ed9ea1b7f591f53a704 100644
--- a/chrome/browser/media/router/discovery/dial/dial_registry.h
+++ b/chrome/browser/media/router/discovery/dial/dial_registry.h
@@ -76,8 +76,8 @@ class DialRegistry : public DialService::Observer,
// Starts and stops periodic discovery. Periodic discovery is done when there
// are registered event listeners.
Kevin M 2017/05/03 21:07:27 Virtual for testing?
zhaobin 2017/05/04 23:52:36 Yes...
- void StartPeriodicDiscovery();
- void StopPeriodicDiscovery();
+ virtual void StartPeriodicDiscovery();
+ virtual void StopPeriodicDiscovery();
// Returns the URL of the device description for the device identified by
// |label|, or an empty GURL if no such device exists.

Powered by Google App Engine
This is Rietveld 408576698