Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/media/router/discovery/media_sink_service_base.h

Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl (Closed)
Patch Set: resolve code review comments from Derek Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/discovery/media_sink_service_base.h
diff --git a/chrome/browser/media/router/discovery/media_sink_service_base.h b/chrome/browser/media/router/discovery/media_sink_service_base.h
index 1c761e4e5f99f85a7dfd466364d202005bb6e7ba..475bc1b0919a8b1e72b09c13702b8ff8e49b1102 100644
--- a/chrome/browser/media/router/discovery/media_sink_service_base.h
+++ b/chrome/browser/media/router/discovery/media_sink_service_base.h
@@ -26,11 +26,16 @@ class MediaSinkServiceBase : public MediaSinkService {
// Called when |finish_timer_| expires.
void OnFetchCompleted();
- // Helper function to start |finish_timer_|.
+ // Helper function to start |finish_timer_|. Create a new timer if none
+ // exists.
void StartTimer();
- // Timer for finishing fetching.
- std::unique_ptr<base::Timer> finish_timer_;
+ // Helper function to stop |finish_timer_|.
+ void StopTimer();
+
+ // Helper function to restart |finish_timer|. No-op if timer does not exist or
+ // timer is currently running.
+ void RestartTimer();
// Time out value for |finish_timer_|
int fetch_complete_timeout_secs_;
@@ -45,6 +50,9 @@ class MediaSinkServiceBase : public MediaSinkService {
friend class MediaSinkServiceBaseTest;
FRIEND_TEST_ALL_PREFIXES(MediaSinkServiceBaseTest,
TestFetchCompleted_SameSink);
+
+ // Timer for finishing fetching.
+ std::unique_ptr<base::Timer> finish_timer_;
};
} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698