chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h - Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h

Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl (Closed)

Patch Set: resolve code review comments from Derek Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/discovery/BUILD.gn ('k') | chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h

diff --git a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h

index cc265fbf04d4077e796745af5ebe387973afd0e8..d84a64c9805dc8d509d1b8a62a89247da945736a 100644

--- a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h

+++ b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h

@@ -47,6 +47,7 @@ class DialMediaSinkServiceImpl : public MediaSinkServiceBase,

FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceImplTest, TestTimer);

FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceImplTest,

TestOnDeviceDescriptionAvailable);

+ FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceImplTest, TestRestartAfterStop);

// api::dial::DialRegistry::Observer implementation

void OnDialDeviceEvent(const DialRegistry::DeviceList& devices) override;

@@ -67,6 +68,9 @@ class DialMediaSinkServiceImpl : public MediaSinkServiceBase,

// Raw pointer to DialRegistry singleton.

DialRegistry* dial_registry_ = nullptr;

+ // DialRegistry for unit test.

+ DialRegistry* test_dial_registry_ = nullptr;

// Device data list from current round of discovery.

DialRegistry::DeviceList current_devices_;