chrome/browser/media/android/router/media_router_android.cc - Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/android/router/media_router_android.cc

Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl (Closed)

Patch Set: resolve code review comments from Derek Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/android/router/media_router_android.cc

diff --git a/chrome/browser/media/android/router/media_router_android.cc b/chrome/browser/media/android/router/media_router_android.cc

index 949e87786c3a20cc75d28de704d6e170b958bf46..4ca58a1cf8a9e99cbca480f8559ab8a3291bbf6a 100644

--- a/chrome/browser/media/android/router/media_router_android.cc

+++ b/chrome/browser/media/android/router/media_router_android.cc

@@ -148,9 +148,8 @@ void MediaRouterAndroid::SearchSinks(

NOTIMPLEMENTED();

}

-void MediaRouterAndroid::ProvideSinks(

- const std::string& provider_name,

- const std::vector<MediaSinkInternal>& sinks) {

+void MediaRouterAndroid::ProvideSinks(const std::string& provider_name,

+ std::vector<MediaSinkInternal> sinks) {

NOTIMPLEMENTED();

}