chrome/common/media_router/discovery/media_sink_service.h - Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/media_router/discovery/media_sink_service.h

Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl (Closed)

Patch Set: resolve code review comments from Kevin Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/media_router/discovery/media_sink_service.h

diff --git a/chrome/common/media_router/discovery/media_sink_service.h b/chrome/common/media_router/discovery/media_sink_service.h

index 5f88cf916e743ee61fabcef3d5faa538de2d51ce..0fb11b5b8e5e659a02edbef26d2a63c0b5a46396 100644

--- a/chrome/common/media_router/discovery/media_sink_service.h

+++ b/chrome/common/media_router/discovery/media_sink_service.h

@@ -24,7 +24,7 @@ class MediaSinkService {

// Callback to be invoked when this class finishes sink discovering.

// Arg 0: Sinks discovered and resolved by the service.

using OnSinksDiscoveredCallback =

- base::Callback<void(const std::vector<MediaSinkInternal>&)>;

+ base::Callback<void(std::vector<MediaSinkInternal>)>;

explicit MediaSinkService(

const OnSinksDiscoveredCallback& sink_discovery_callback);