[Media Router] Use DialMediaSinkService in MediaRouterMojoImpl

chrome/browser/media/router/media_router.h

Index: chrome/browser/media/router/media_router.h
diff --git a/chrome/browser/media/router/media_router.h b/chrome/browser/media/router/media_router.h
index c14a7302846abebb2215737f6f592fdb67ef7c92..0e2a873b80b76da6f17fccfa4f7b9caa8b80de60 100644
--- a/chrome/browser/media/router/media_router.h
+++ b/chrome/browser/media/router/media_router.h
@@ -178,7 +178,7 @@ class MediaRouter : public KeyedService {
   // |provider_name|: Name of the MediaSinkService providing the sinks.
   // |sinks|: sinks discovered by MediaSinkService.
   virtual void ProvideSinks(const std::string& provider_name,
-                            const std::vector<MediaSinkInternal>& sinks) = 0;
+                            std::vector<MediaSinkInternal> sinks) = 0;

[imcheng, 2017/05/26 01:26:00]

similar to the other comment about using std::move. This method is used in
base::Bind as a base::Callback. So |sinks| is the reference is to the vector
that was (safely) copied into the callback's internal storage.

[zhaobin, 2017/05/26 20:59:40]

To avoid copy as Mark suggested...

 
   // Adds |callback| to listen for state changes for presentation connected to
   // |route_id|. The returned Subscription object is owned by the caller.