[Media Router] Use DialMediaSinkService in MediaRouterMojoImpl

chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc

Index: chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
diff --git a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a969e8108375a5eb614ace49d8727aa2079eb9d1
--- /dev/null
+++ b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
@@ -0,0 +1,98 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy.h"
+#include "base/run_loop.h"
+#include "base/test/mock_callback.h"
+#include "chrome/browser/media/router/discovery/dial/dial_media_sink_service.h"
+#include "chrome/browser/media/router/test_helper.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using ::testing::_;
+using ::testing::Return;
+
+namespace media_router {
+
+class MockDialMediaSinkService : public DialMediaSinkService {
+ public:
+  MockDialMediaSinkService(const MediaSinkService::OnSinksDiscoveredCallback&
+                               sink_discovery_callback,
+                           net::URLRequestContextGetter* request_context)
+      : DialMediaSinkService(sink_discovery_callback, request_context) {}
+  ~MockDialMediaSinkService() override {}
+
+  MOCK_METHOD0(Start, void());
+  MOCK_METHOD0(Stop, void());
+
+  void OnSinksDiscovered() {
+    sink_discovery_callback_.Run(std::vector<MediaSinkInternal>());
+  }
+};
+
+class DialMediaSinkServiceProxyTest : public ::testing::Test {
+ public:
+  DialMediaSinkServiceProxyTest()
+      : proxy_(new DialMediaSinkServiceProxy(mock_sink_discovered_cb_.Get(),
+                                             profile_.GetRequestContext())) {
+    std::unique_ptr<MockDialMediaSinkService,
+                    content::BrowserThread::DeleteOnIOThread>
+        mock_dial_media_sink_service;
+    mock_dial_media_sink_service.reset(new MockDialMediaSinkService(
+        base::Bind(&DialMediaSinkServiceProxy::OnSinksDiscoveredOnIOThread,
+                   base::Unretained(proxy_.get())),
+        profile_.GetRequestContext()));
+    mock_service_ = mock_dial_media_sink_service.get();
+    proxy_->SetDialMediaSinkServiceForTest(
+        std::move(mock_dial_media_sink_service));
+  }
+
+  void TearDown() override { base::RunLoop().RunUntilIdle(); }
+
+ protected:
+  const content::TestBrowserThreadBundle thread_bundle_;
+  TestingProfile profile_;
+
+  base::MockCallback<MediaSinkService::OnSinksDiscoveredCallback>
+      mock_sink_discovered_cb_;
+
+  MockDialMediaSinkService* mock_service_;
+  scoped_refptr<DialMediaSinkServiceProxy> proxy_;
+
+  DISALLOW_COPY_AND_ASSIGN(DialMediaSinkServiceProxyTest);
+};
+
+TEST_F(DialMediaSinkServiceProxyTest, TestStart) {
+  EXPECT_CALL(*mock_service_, Start());

[Kevin M, 2017/05/15 19:56:58]

Verifying that the proxy is invoking a function is really only half of the story
for the proxy class. :) Can we have a custom action that verifies that the calls
are being run on the I/O thread?

I think a custom action might work:

EXPECT_CALL(cb, Run(_))
  .WillOnce(InvokeWithoutArgs(AssertOnIOThread))

[zhaobin, 2017/05/16 21:26:49]

Done.

+
+  proxy_->Start();
+}
+
+TEST_F(DialMediaSinkServiceProxyTest, TestStop) {
+  EXPECT_CALL(*mock_service_, Stop());
+
+  proxy_->Stop();
+}
+
+TEST_F(DialMediaSinkServiceProxyTest, TestOnSinksDiscovered) {
+  EXPECT_CALL(*mock_service_, Start());
+  EXPECT_CALL(mock_sink_discovered_cb_, Run(_)).Times(1);
+
+  proxy_->Start();
+  mock_service_->OnSinksDiscovered();
+}
+
+TEST_F(DialMediaSinkServiceProxyTest, TestOnSinksDiscoveredAfterStop) {
+  EXPECT_CALL(*mock_service_, Start());
+  EXPECT_CALL(*mock_service_, Stop());
+  EXPECT_CALL(mock_sink_discovered_cb_, Run(_)).Times(0);
+
+  proxy_->Start();
+  proxy_->Stop();
+  mock_service_->OnSinksDiscovered();
+}
+
+}  // namespace media_router