[Media Router] Use DialMediaSinkService in MediaRouterMojoImpl

chrome/browser/media/router/discovery/dial/dial_media_sink_service_delegate_unittest.cc

Index: chrome/browser/media/router/discovery/dial/dial_media_sink_service_delegate_unittest.cc
diff --git a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_delegate_unittest.cc b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_delegate_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ec9410b2fd1136106de9d81e5dde4668dbfde0f3
--- /dev/null
+++ b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_delegate_unittest.cc
@@ -0,0 +1,102 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/router/discovery/dial/dial_media_sink_service_delegate.h"
+#include "base/run_loop.h"
+#include "base/test/mock_callback.h"
+#include "chrome/browser/media/router/discovery/dial/dial_media_sink_service.h"
+#include "chrome/browser/media/router/test_helper.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using ::testing::_;
+using ::testing::Return;
+
+namespace media_router {
+
+class MockDialMediaSinkService : public DialMediaSinkService {
+ public:
+  MockDialMediaSinkService(const MediaSinkService::OnSinksDiscoveredCallback&
+                               sink_discovery_callback,
+                           net::URLRequestContextGetter* request_context)
+      : DialMediaSinkService(sink_discovery_callback, request_context) {}
+  ~MockDialMediaSinkService() override {}
+
+  MOCK_METHOD0(Start, void());
+  MOCK_METHOD0(Stop, void());
+
+  void OnSinksDiscovered() {
+    sink_discovery_callback_.Run(std::vector<MediaSinkInternal>());
+  }
+};
+
+class DialMediaSinkServiceDelegateTest : public ::testing::Test {
+ public:
+  DialMediaSinkServiceDelegateTest()
+      : delegate_(new DialMediaSinkServiceDelegate()) {
+    std::unique_ptr<MockDialMediaSinkService,
+                    content::BrowserThread::DeleteOnIOThread>
+        mock_dial_media_sink_service;

[mark a. foltz, 2017/05/12 21:37:38]

= MakeUnique<MockDialMediaSinkService>(...)

[zhaobin, 2017/05/12 23:03:38]

MakeUnique<> cannot take content::BrowserThread::DeleteOnIOThread...

+    mock_dial_media_sink_service.reset(new MockDialMediaSinkService(
+        base::Bind(&DialMediaSinkServiceDelegate::OnSinksDiscoveredOnIOThread,
+                   base::Unretained(delegate_.get())),
+        profile_.GetRequestContext()));
+    mock_service_ = mock_dial_media_sink_service.get();
+    delegate_->SetDialMediaSinkServiceForTest(
+        std::move(mock_dial_media_sink_service));
+  }
+
+ protected:
+  const content::TestBrowserThreadBundle thread_bundle_;
+  TestingProfile profile_;
+
+  base::MockCallback<MediaSinkService::OnSinksDiscoveredCallback>
+      mock_sink_discovered_cb_;
+
+  MockDialMediaSinkService* mock_service_;
+  scoped_refptr<DialMediaSinkServiceDelegate> delegate_;
+
+  DISALLOW_COPY_AND_ASSIGN(DialMediaSinkServiceDelegateTest);
+};
+
+TEST_F(DialMediaSinkServiceDelegateTest, TestStart) {
+  EXPECT_CALL(*mock_service_, Start());
+
+  delegate_->Start(mock_sink_discovered_cb_.Get(),
+                   profile_.GetRequestContext());
+  base::RunLoop().RunUntilIdle();

[mark a. foltz, 2017/05/12 21:37:38]

Nit: This can be put in TearDown().

[zhaobin, 2017/05/12 23:03:38]

Done.

+}
+
+TEST_F(DialMediaSinkServiceDelegateTest, TestStop) {
+  EXPECT_CALL(*mock_service_, Stop());
+
+  delegate_->Stop();
+  base::RunLoop().RunUntilIdle();
+}
+
+TEST_F(DialMediaSinkServiceDelegateTest, TestOnSinksDiscovered) {
+  EXPECT_CALL(*mock_service_, Start());
+  EXPECT_CALL(mock_sink_discovered_cb_, Run(_));

[mark a. foltz, 2017/05/12 21:37:38]

Nit: .Times(1)

[zhaobin, 2017/05/12 23:03:39]

Done.

+
+  delegate_->Start(mock_sink_discovered_cb_.Get(),
+                   profile_.GetRequestContext());
+  mock_service_->OnSinksDiscovered();
+  base::RunLoop().RunUntilIdle();
+}
+
+TEST_F(DialMediaSinkServiceDelegateTest, TestOnSinksDiscoveredAfterStop) {
+  EXPECT_CALL(*mock_service_, Start());
+  EXPECT_CALL(*mock_service_, Stop());
+  EXPECT_CALL(mock_sink_discovered_cb_, Run(_)).Times(0);
+
+  delegate_->Start(mock_sink_discovered_cb_.Get(),
+                   profile_.GetRequestContext());
+  delegate_->Stop();
+  mock_service_->OnSinksDiscovered();
+  base::RunLoop().RunUntilIdle();
+}
+
+}  // namespace media_router