Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: chrome/browser/media/router/mojo/media_router_mojo_test.cc

Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl (Closed)
Patch Set: resolve code review comments from Kevin Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/mojo/media_router_mojo_test.h" 5 #include "chrome/browser/media/router/mojo/media_router_mojo_test.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "extensions/common/test_util.h" 10 #include "extensions/common/test_util.h"
11 11
12 namespace media_router { 12 namespace media_router {
13 namespace { 13 namespace {
14
15 const char kInstanceId[] = "instance123"; 14 const char kInstanceId[] = "instance123";
16
17 void ExpectEqualStrings(const std::string& expected,
18 const std::string& actual) {
19 EXPECT_EQ(expected, actual);
20 }
21
22 } // namespace 15 } // namespace
23 16
24 MockMediaRouteProvider::MockMediaRouteProvider() {} 17 MockMediaRouteProvider::MockMediaRouteProvider() {}
25 18
26 MockMediaRouteProvider::~MockMediaRouteProvider() {} 19 MockMediaRouteProvider::~MockMediaRouteProvider() {}
27 20
28 MockEventPageTracker::MockEventPageTracker() {} 21 MockEventPageTracker::MockEventPageTracker() {}
29 22
30 MockEventPageTracker::~MockEventPageTracker() {} 23 MockEventPageTracker::~MockEventPageTracker() {}
31 24
32 MockMediaController::MockMediaController() : binding_(this) {} 25 MockMediaController::MockMediaController() : binding_(this) {}
33 26
34 MockMediaController::~MockMediaController() {} 27 MockMediaController::~MockMediaController() {}
35 28
29 RegisterMediaRouteProviderHandler::RegisterMediaRouteProviderHandler() {}
Kevin M 2017/05/08 18:22:19 Separate these with newlines
zhaobin 2017/05/08 20:13:48 Done.
30 RegisterMediaRouteProviderHandler::~RegisterMediaRouteProviderHandler() {}
31
36 void MockMediaController::Bind(mojom::MediaControllerRequest request) { 32 void MockMediaController::Bind(mojom::MediaControllerRequest request) {
37 binding_.Bind(std::move(request)); 33 binding_.Bind(std::move(request));
38 } 34 }
39 35
40 mojom::MediaControllerPtr MockMediaController::BindInterfacePtr() { 36 mojom::MediaControllerPtr MockMediaController::BindInterfacePtr() {
41 return binding_.CreateInterfacePtrAndBind(); 37 return binding_.CreateInterfacePtrAndBind();
42 } 38 }
43 39
44 void MockMediaController::CloseBinding() { 40 void MockMediaController::CloseBinding() {
45 binding_.Close(); 41 binding_.Close();
46 } 42 }
47 43
48 MockMediaRouteControllerObserver::MockMediaRouteControllerObserver( 44 MockMediaRouteControllerObserver::MockMediaRouteControllerObserver(
49 scoped_refptr<MediaRouteController> controller) 45 scoped_refptr<MediaRouteController> controller)
50 : MediaRouteController::Observer(controller) {} 46 : MediaRouteController::Observer(controller) {}
51 47
52 MockMediaRouteControllerObserver::~MockMediaRouteControllerObserver() {} 48 MockMediaRouteControllerObserver::~MockMediaRouteControllerObserver() {}
53 49
54 MediaRouterMojoTest::MediaRouterMojoTest() 50 MediaRouterMojoTest::MediaRouterMojoTest()
55 : mock_media_router_(new MediaRouterMojoImpl(&mock_event_page_tracker_)) { 51 : mock_media_router_(
52 new MediaRouterMojoImpl(&mock_event_page_tracker_, &profile_)) {
56 mock_media_router_->Initialize(); 53 mock_media_router_->Initialize();
57 mock_media_router_->set_instance_id_for_test(kInstanceId); 54 mock_media_router_->set_instance_id_for_test(kInstanceId);
58 extension_ = extensions::test_util::CreateEmptyExtension(); 55 extension_ = extensions::test_util::CreateEmptyExtension();
59 } 56 }
60 57
61 MediaRouterMojoTest::~MediaRouterMojoTest() {} 58 MediaRouterMojoTest::~MediaRouterMojoTest() {}
62 59
63 void MediaRouterMojoTest::ConnectProviderManagerService() { 60 void MediaRouterMojoTest::ConnectProviderManagerService() {
64 // Bind the |media_route_provider| interface to |media_route_provider_|. 61 // Bind the |media_route_provider| interface to |media_route_provider_|.
65 auto request = mojo::MakeRequest(&media_router_proxy_); 62 auto request = mojo::MakeRequest(&media_router_proxy_);
66 mock_media_router_->BindToMojoRequest(std::move(request), *extension_); 63 mock_media_router_->BindToMojoRequest(std::move(request), *extension_);
67 64
68 // Bind the Mojo MediaRouter interface used by |mock_media_router_| to 65 // Bind the Mojo MediaRouter interface used by |mock_media_router_| to
69 // |mock_media_route_provider_service_|. 66 // |mock_media_route_provider_service_|.
70 mojom::MediaRouteProviderPtr mojo_media_router; 67 mojom::MediaRouteProviderPtr mojo_media_router;
71 binding_.reset(new mojo::Binding<mojom::MediaRouteProvider>( 68 binding_.reset(new mojo::Binding<mojom::MediaRouteProvider>(
72 &mock_media_route_provider_, mojo::MakeRequest(&mojo_media_router))); 69 &mock_media_route_provider_, mojo::MakeRequest(&mojo_media_router)));
70 EXPECT_CALL(provide_handler_, InvokeRaw(kInstanceId, testing::_));
73 media_router_proxy_->RegisterMediaRouteProvider( 71 media_router_proxy_->RegisterMediaRouteProvider(
74 std::move(mojo_media_router), 72 std::move(mojo_media_router),
75 base::Bind(&ExpectEqualStrings, kInstanceId)); 73 base::Bind(&RegisterMediaRouteProviderHandler::Invoke,
74 base::Unretained(&provide_handler_)));
76 } 75 }
77 76
78 void MediaRouterMojoTest::SetUp() { 77 void MediaRouterMojoTest::SetUp() {
79 ON_CALL(mock_event_page_tracker_, IsEventPageSuspended(extension_id())) 78 ON_CALL(mock_event_page_tracker_, IsEventPageSuspended(extension_id()))
80 .WillByDefault(testing::Return(false)); 79 .WillByDefault(testing::Return(false));
81 ConnectProviderManagerService(); 80 ConnectProviderManagerService();
82 base::RunLoop().RunUntilIdle(); 81 base::RunLoop().RunUntilIdle();
83 } 82 }
84 83
85 void MediaRouterMojoTest::TearDown() { 84 void MediaRouterMojoTest::TearDown() {
86 mock_media_router_->Shutdown(); 85 mock_media_router_->Shutdown();
87 } 86 }
88 87
89 void MediaRouterMojoTest::ProcessEventLoop() { 88 void MediaRouterMojoTest::ProcessEventLoop() {
90 base::RunLoop().RunUntilIdle(); 89 base::RunLoop().RunUntilIdle();
91 } 90 }
92 91
93 } // namespace media_router 92 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698