OLD | NEW |
---|---|
1 // Copyright 2017 The Chromium Authors. All rights reserved. | 1 // Copyright 2017 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DIAL_DIAL_MEDIA_SINK_SERVICE_H_ | 5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DIAL_DIAL_MEDIA_SINK_SERVICE_H_ |
6 #define CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DIAL_DIAL_MEDIA_SINK_SERVICE_H_ | 6 #define CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DIAL_DIAL_MEDIA_SINK_SERVICE_H_ |
7 | 7 |
8 #include <memory> | 8 #include <memory> |
9 #include <set> | 9 #include <set> |
10 | 10 |
11 #include "base/memory/ref_counted.h" | |
11 #include "chrome/browser/media/router/discovery/dial/device_description_service. h" | 12 #include "chrome/browser/media/router/discovery/dial/device_description_service. h" |
12 #include "chrome/browser/media/router/discovery/dial/dial_registry.h" | 13 #include "chrome/browser/media/router/discovery/dial/dial_registry.h" |
13 #include "chrome/common/media_router/discovery/media_sink_internal.h" | 14 #include "chrome/common/media_router/discovery/media_sink_internal.h" |
14 #include "chrome/common/media_router/discovery/media_sink_service.h" | 15 #include "chrome/common/media_router/discovery/media_sink_service.h" |
16 #include "content/public/browser/browser_thread.h" | |
15 | 17 |
16 namespace media_router { | 18 namespace media_router { |
17 | 19 |
18 class DeviceDescriptionService; | 20 class DeviceDescriptionService; |
19 class DialRegistry; | 21 class DialRegistry; |
20 | 22 |
21 // A service which can be used to start background discovery and resolution of | 23 // A service which can be used to start background discovery and resolution of |
22 // DIAL devices (Smart TVs, Game Consoles, etc.). | 24 // DIAL devices (Smart TVs, Game Consoles, etc.). |
23 // This class is not thread safe. All methods must be called from the IO thread. | 25 // This class is thread safe. It is created on UI thread and destroyed on IO |
Kevin M
2017/05/03 21:07:27
* If it was threadsafe then one could use it on an
zhaobin
2017/05/04 23:52:35
Methods in this class can be invoked on both UI an
| |
24 class DialMediaSinkService : public MediaSinkService, | 26 // thread. |
27 class DialMediaSinkService : public base::RefCountedThreadSafe< | |
Kevin M
2017/05/03 21:07:27
totally low pri nit: move RefCountedThreadSafe to
zhaobin
2017/05/04 23:52:35
Done.
| |
28 DialMediaSinkService, | |
29 content::BrowserThread::DeleteOnIOThread>, | |
30 public MediaSinkService, | |
25 public DialRegistry::Observer { | 31 public DialRegistry::Observer { |
26 public: | 32 public: |
27 DialMediaSinkService(const OnSinksDiscoveredCallback& callback, | 33 DialMediaSinkService(const OnSinksDiscoveredCallback& callback, |
28 net::URLRequestContextGetter* request_context); | 34 net::URLRequestContextGetter* request_context); |
29 ~DialMediaSinkService() override; | |
30 | 35 |
31 // MediaSinkService implementation | 36 // MediaSinkService implementation |
32 void Start() override; | 37 void Start() override; |
33 | 38 |
34 void Stop(); | 39 void Stop(); |
Kevin M
2017/05/03 21:07:27
Move non-overrides above overrides.
zhaobin
2017/05/04 23:52:35
Done.
| |
35 | 40 |
36 protected: | 41 protected: |
42 ~DialMediaSinkService() override; | |
43 | |
44 // Returns instance of device registry. | |
Kevin M
2017/05/03 21:07:27
Document why this is protected virtual? (testing,
zhaobin
2017/05/04 23:52:35
Done.
| |
37 virtual DialRegistry* dial_registry(); | 45 virtual DialRegistry* dial_registry(); |
38 | 46 |
39 // Returns instance of device description service. Create a new one if none | 47 // Returns instance of device description service. Create a new one if none |
40 // exists. | 48 // exists. |
41 virtual DeviceDescriptionService* GetDescriptionService(); | 49 virtual DeviceDescriptionService* GetDescriptionService(); |
42 | 50 |
43 private: | 51 private: |
52 friend struct content::BrowserThread::DeleteOnThread< | |
53 content::BrowserThread::IO>; | |
54 friend class base::DeleteHelper<DialMediaSinkService>; | |
44 friend class DialMediaSinkServiceTest; | 55 friend class DialMediaSinkServiceTest; |
45 FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceTest, TestStart); | 56 FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceTest, TestStart); |
46 FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceTest, TestFetchCompleted); | 57 FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceTest, |
58 TestFetchCompleted_SameSink); | |
47 FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceTest, TestIsDifferent); | 59 FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceTest, TestIsDifferent); |
48 FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceTest, | 60 FRIEND_TEST_ALL_PREFIXES(DialMediaSinkServiceTest, |
49 TestOnDeviceDescriptionAvailable); | 61 TestOnDeviceDescriptionAvailable); |
50 | 62 |
63 // Start discovery on IO thread. | |
64 void StartOnIOThread(); | |
65 | |
66 // Stop discovery on IO thread. | |
67 void StopOnIOThread(); | |
68 | |
69 // Called when |finish_timer_| expires. | |
70 void OnFetchCompletedOnUIThread(); | |
71 | |
51 // api::dial::DialRegistry::Observer implementation | 72 // api::dial::DialRegistry::Observer implementation |
52 void OnDialDeviceEvent(const DialRegistry::DeviceList& devices) override; | 73 void OnDialDeviceEvent(const DialRegistry::DeviceList& devices) override; |
53 void OnDialError(DialRegistry::DialErrorCode type) override; | 74 void OnDialError(DialRegistry::DialErrorCode type) override; |
54 | 75 |
55 // Called when description service successfully fetches and parses device | 76 // Called when description service successfully fetches and parses device |
56 // description XML. Restart |finish_timer_| if it is not running. | 77 // description XML. Restart |finish_timer_| if it is not running. |
57 void OnDeviceDescriptionAvailable( | 78 void OnDeviceDescriptionAvailable( |
58 const DialDeviceData& device_data, | 79 const DialDeviceData& device_data, |
59 const ParsedDialDeviceDescription& description_data); | 80 const ParsedDialDeviceDescription& description_data); |
60 | 81 |
61 // Called when fails to fetch or parse device description XML. | 82 // Called when fails to fetch or parse device description XML. |
62 void OnDeviceDescriptionError(const DialDeviceData& device, | 83 void OnDeviceDescriptionError(const DialDeviceData& device, |
63 const std::string& error_message); | 84 const std::string& error_message); |
64 | 85 |
65 // Called when |finish_timer_| expires. | 86 // Called when |finish_timer_| expires and post task on UI thread. |
66 void OnFetchCompleted(); | 87 void OnFetchCompleted(); |
67 | 88 |
68 // Timer for finishing fetching. Starts in |OnDialDeviceEvent()|, and expires | 89 // Timer for finishing fetching. Starts in |OnDialDeviceEvent()|, and expires |
69 // 3 seconds later. If |OnDeviceDescriptionAvailable()| is called after | 90 // 3 seconds later. If |OnDeviceDescriptionAvailable()| is called after |
70 // |finish_timer_| expires, |finish_timer_| is restarted. | 91 // |finish_timer_| expires, |finish_timer_| is restarted. |
71 std::unique_ptr<base::OneShotTimer> finish_timer_; | 92 std::unique_ptr<base::OneShotTimer> finish_timer_; |
72 | 93 |
73 std::unique_ptr<DeviceDescriptionService> description_service_; | 94 std::unique_ptr<DeviceDescriptionService> description_service_; |
74 | 95 |
75 // Sorted sinks from current round of discovery. | 96 // Sorted sinks from current round of discovery. |
76 std::set<MediaSinkInternal> current_sinks_; | 97 std::set<MediaSinkInternal> current_sinks_; |
77 | 98 |
78 // Sorted sinks sent to Media Router Provider in last FetchCompleted(). | 99 // Sorted sinks sent to Media Router Provider in last FetchCompleted(). |
79 std::set<MediaSinkInternal> mrp_sinks_; | 100 std::set<MediaSinkInternal> mrp_sinks_; |
80 | 101 |
81 // Device data list from current round of discovery. | 102 // Device data list from current round of discovery. |
82 DialRegistry::DeviceList current_devices_; | 103 DialRegistry::DeviceList current_devices_; |
83 | 104 |
84 scoped_refptr<net::URLRequestContextGetter> request_context_; | 105 scoped_refptr<net::URLRequestContextGetter> request_context_; |
85 }; | 106 }; |
86 | 107 |
87 } // namespace media_router | 108 } // namespace media_router |
88 | 109 |
89 #endif // CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DIAL_DIAL_MEDIA_SINK_SERVICE_H_ | 110 #endif // CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DIAL_DIAL_MEDIA_SINK_SERVICE_H_ |
OLD | NEW |