[Media Router] Use DialMediaSinkService in MediaRouterMojoImpl

chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h"
 #include "base/test/mock_callback.h"
 #include "base/timer/mock_timer.h"
 #include "chrome/browser/media/router/discovery/dial/dial_device_data.h"
 #include "chrome/browser/media/router/discovery/dial/dial_registry.h"
 #include "chrome/browser/media/router/test_helper.h"
@@ skipping 78 matching lines @@
 
   TestDialRegistry test_dial_registry_;
   MockDeviceDescriptionService* mock_description_service_;
   base::MockTimer* mock_timer_;
 
   std::unique_ptr<DialMediaSinkServiceImpl> media_sink_service_;
 
   DISALLOW_COPY_AND_ASSIGN(DialMediaSinkServiceImplTest);
 };
 
-TEST_F(DialMediaSinkServiceImplTest, TestStart) {
-  media_sink_service_->Start();
-
-  DialRegistry::DeviceList deviceList;
-  DialDeviceData first_device("first", GURL("http://127.0.0.1/dd.xml"),
-                              base::Time::Now());
-  DialDeviceData second_device("second", GURL("http://127.0.0.2/dd.xml"),
-                               base::Time::Now());
-  DialDeviceData third_device("third", GURL("http://127.0.0.3/dd.xml"),
-                              base::Time::Now());
-  deviceList.push_back(first_device);
-  deviceList.push_back(second_device);
-  deviceList.push_back(third_device);
-
-  EXPECT_CALL(*mock_description_service_, GetDeviceDescriptions(deviceList, _));
-
-  media_sink_service_->OnDialDeviceEvent(deviceList);
-  EXPECT_TRUE(media_sink_service_->finish_timer_->IsRunning());
-}
-
 TEST_F(DialMediaSinkServiceImplTest, TestOnDeviceDescriptionAvailable) {
   DialDeviceData device_data("first", GURL("http://127.0.0.1/dd.xml"),
                              base::Time::Now());
   ParsedDialDeviceDescription device_description;
   device_description.model_name = "model name";
   device_description.friendly_name = "friendly name";
   device_description.app_url = GURL("http://192.168.1.1/apps");
   device_description.unique_id = "unique id";
 
   media_sink_service_->OnDeviceDescriptionAvailable(device_data,
@@ skipping 31 matching lines @@
   EXPECT_CALL(mock_sink_discovered_cb_, Run(_));
   mock_timer_->Fire();
 
   EXPECT_FALSE(mock_timer_->IsRunning());
   device_description.app_url = GURL("http://192.168.1.11/apps");
   media_sink_service_->OnDeviceDescriptionAvailable(device_data,
                                                     device_description);
   EXPECT_TRUE(mock_timer_->IsRunning());
 }
 
 }  // namespace media_router

[Kevin M, 2017/05/24 00:52:55]

Can you add a test case that Starts, Stops, and reStarts the service impl
object? That would've caught the unique_ptr segfault bug.

[zhaobin, 2017/05/24 17:45:51]

Done.