src/ppc/code-stubs-ppc.cc - Issue 2837283004: PPC/s390: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ppc/code-stubs-ppc.cc

Issue 2837283004: PPC/s390: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ppc/code-stubs-ppc.cc

diff --git a/src/ppc/code-stubs-ppc.cc b/src/ppc/code-stubs-ppc.cc

index 6e6de3370a8d8969e9a4cb4e20c922d504f06f60..beeb66b44277f1fe14667b4c46ba9362ff4540c1 100644

--- a/src/ppc/code-stubs-ppc.cc

+++ b/src/ppc/code-stubs-ppc.cc

@@ -2946,9 +2946,7 @@ void CallApiCallbackStub::Generate(MacroAssembler* masm) {

__ push(call_data);

- if (!call_data_undefined()) {

- __ LoadRoot(scratch, Heap::kUndefinedValueRootIndex);

- }

+ __ LoadRoot(scratch, Heap::kUndefinedValueRootIndex);

// return value

__ push(scratch);

// return value default

« no previous file with comments | « src/ic/s390/handler-compiler-s390.cc ('k') | src/s390/code-stubs-s390.cc » ('j') | no next file with comments »