chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java - Issue 2837283003: [Android] Log notification shown/blocked for all other notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java

Issue 2837283003: [Android] Log notification shown/blocked for all other notifications (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBroadcastService.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerServiceLifecycleTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java

index 8f99e40444bdcf9c7cbc9323ab793318e7f582d8..ea8a1d51f8833561dd8f4f28c49c13169c74e35a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java

@@ -22,6 +22,7 @@ import org.chromium.chrome.browser.notifications.NotificationBuilderFactory;

import org.chromium.chrome.browser.notifications.NotificationConstants;

import org.chromium.chrome.browser.notifications.NotificationManagerProxy;

import org.chromium.chrome.browser.notifications.NotificationManagerProxyImpl;

+import org.chromium.chrome.browser.notifications.NotificationUmaTracker;

import org.chromium.chrome.browser.preferences.PreferencesLauncher;

import org.chromium.components.sync.AndroidSyncSettings;

@@ -118,6 +119,8 @@ public class SyncNotificationController implements ProfileSyncService.SyncStateC

Notification notification = builder.buildWithBigTextStyle(text);

mNotificationManager.notify(NotificationConstants.NOTIFICATION_ID_SYNC, notification);

+ NotificationUmaTracker.getInstance().onNotificationShown(

+ NotificationUmaTracker.SYNC, ChannelDefinitions.CHANNEL_ID_BROWSER);

}

private boolean shouldSyncAuthErrorBeShown() {