Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: media/capture/video/chromeos/stream_buffer_manager.cc

Issue 2837273004: media: add video capture device for ARC++ camera HAL v3 (Closed)
Patch Set: add more device delegate test cases Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "media/capture/video/chromeos/camera_device_delegate.h"
6
7 #include "media/capture/video/chromeos/camera_hal_delegate.h"
8 #include "media/capture/video/chromeos/camera_metadata_utils.h"
9 #include "media/capture/video/chromeos/pixel_format_utils.h"
10 #include "mojo/edk/embedder/embedder.h"
11 #include "mojo/edk/embedder/scoped_platform_handle.h"
12 #include "third_party/libsync/include/sync/sync.h"
13
14 namespace media {
15
16 CameraDeviceDelegate::StreamBufferManager::StreamBufferManager(
17 arc::mojom::Camera3CallbackOpsRequest callback_ops_request,
18 scoped_refptr<CameraDeviceDelegate> camera_device_delegate,
19 scoped_refptr<base::SingleThreadTaskRunner> ipc_task_runner)
20 : capturing_(false),
21 camera_device_delegate_(std::move(camera_device_delegate)),
22 callback_ops_(this, std::move(callback_ops_request)),
23 ipc_task_runner_(std::move(ipc_task_runner)),
24 frame_number_(0),
25 partial_result_count_(1),
26 first_frame_shutter_time_(base::TimeTicks::Now()) {}
27
28 void CameraDeviceDelegate::StreamBufferManager::SetUpStreamAndBuffers(
29 VideoCaptureFormat capture_format,
30 uint32_t partial_result_count,
31 arc::mojom::Camera3StreamPtr stream) {
32 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
33 DCHECK(!stream_context_);
34
35 VLOG(2) << "Stream " << stream->id << " configured: usage=" << stream->usage
36 << " max_buffers=" << stream->max_buffers;
37
38 const size_t kMaximumAllowedBuffers = 15;
39 if (stream->max_buffers > kMaximumAllowedBuffers) {
40 camera_device_delegate_->SetErrorState(
41 FROM_HERE, std::string("Camera HAL requested ") +
42 std::to_string(stream->max_buffers) +
43 std::string(" buffers which exceeds the allowed maximum "
44 "number of buffers"));
45 return;
46 }
47
48 partial_result_count_ = partial_result_count;
49 stream_context_.reset(new StreamContext{capture_format, std::move(stream)});
50
51 // Allocate buffers.
52 size_t num_buffers = stream_context_->stream->max_buffers;
53 stream_context_->buffers.resize(num_buffers);
54 for (size_t j = 0; j < num_buffers; ++j) {
55 const VideoCaptureFormat frame_format(
56 gfx::Size(stream_context_->stream->width,
57 stream_context_->stream->height),
58 0.0, stream_context_->capture_format.pixel_format);
59 std::unique_ptr<base::SharedMemory> buffer(new base::SharedMemory());
60 base::SharedMemoryCreateOptions options;
61 options.size = frame_format.ImageAllocationSize();
62 options.share_read_only = false;
63 bool ret = buffer->Create(options);
64 if (!ret) {
65 camera_device_delegate_->SetErrorState(
66 FROM_HERE, "Failed to create SharedMemory buffer");
67 return;
68 }
69 ret = buffer->Map(buffer->requested_size());
70 if (!ret) {
71 camera_device_delegate_->SetErrorState(
72 FROM_HERE, "Failed to map SharedMemory buffer");
73 return;
74 }
75 stream_context_->buffers[j] = std::move(buffer);
76 stream_context_->free_buffers.push(j);
77 }
78 VLOG(2) << "Allocated " << stream_context_->stream->max_buffers << " buffers";
79 }
80
81 void CameraDeviceDelegate::StreamBufferManager::StartCapture(
82 arc::mojom::CameraMetadataPtr settings) {
83 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
84 DCHECK(stream_context_);
85 DCHECK(stream_context_->request_settings.is_null());
86
87 capturing_ = true;
88 stream_context_->request_settings = std::move(settings);
89 // We cannot use a loop to register all the free buffers in one shot here
90 // because the camera HAL v3 API specifies that the client cannot call
91 // ProcessCaptureRequest before the previous one returns.
92 RegisterBuffer();
93 }
94
95 void CameraDeviceDelegate::StreamBufferManager::StopCapture() {
96 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
97 capturing_ = false;
98 }
99
100 void CameraDeviceDelegate::StreamBufferManager::RegisterBuffer() {
101 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
102 DCHECK(stream_context_);
103
104 if (!capturing_) {
105 return;
106 }
107
108 if (stream_context_->free_buffers.empty()) {
109 return;
110 }
111
112 size_t buffer_id = stream_context_->free_buffers.front();
113 stream_context_->free_buffers.pop();
114 const base::SharedMemory* buffer = stream_context_->buffers[buffer_id].get();
115
116 VideoPixelFormat buffer_format = stream_context_->capture_format.pixel_format;
117 uint32_t drm_format = PixFormatChromiumToDrm(buffer_format);
118 if (!drm_format) {
119 camera_device_delegate_->SetErrorState(
120 FROM_HERE, std::string("Unsupported video pixel format") +
121 VideoPixelFormatToString(buffer_format));
122 return;
123 }
124 arc::mojom::HalPixelFormat hal_pixel_format = stream_context_->stream->format;
125
126 size_t num_planes = VideoFrame::NumPlanes(buffer_format);
127 std::vector<mojo::ScopedHandle> fds(num_planes);
128 std::vector<uint32_t> strides(num_planes);
129 std::vector<uint32_t> offsets(num_planes);
130 for (size_t i = 0; i < num_planes; ++i) {
131 base::SharedMemoryHandle shm_handle = buffer->handle();
132 // Wrap the platform handle.
133 MojoHandle wrapped_handle;
134 MojoResult result = mojo::edk::CreatePlatformHandleWrapper(
135 mojo::edk::ScopedPlatformHandle(mojo::edk::PlatformHandle(
136 base::SharedMemory::DuplicateHandle(shm_handle).GetHandle())),
137 &wrapped_handle);
138 if (result != MOJO_RESULT_OK) {
139 camera_device_delegate_->SetErrorState(
140 FROM_HERE, "Failed to wrap shared memory handle");
141 return;
142 }
143 fds[i].reset(mojo::Handle(wrapped_handle));
144 strides[i] = VideoFrame::RowBytes(
145 i, buffer_format, stream_context_->capture_format.frame_size.width());
146 if (!i) {
147 offsets[i] = 0;
148 } else {
149 offsets[i] =
150 offsets[i - 1] +
151 VideoFrame::PlaneSize(buffer_format, i - 1,
152 stream_context_->capture_format.frame_size)
153 .GetArea();
154 }
155 }
156 camera_device_delegate_->RegisterBuffer(
157 buffer_id, arc::mojom::Camera3DeviceOps::BufferType::SHM, std::move(fds),
158 drm_format, hal_pixel_format, stream_context_->stream->width,
159 stream_context_->stream->height, std::move(strides), std::move(offsets),
160 base::Bind(&CameraDeviceDelegate::StreamBufferManager::OnRegisteredBuffer,
161 this, buffer_id));
162 VLOG(2) << "Registered buffer " << buffer_id;
163 }
164
165 void CameraDeviceDelegate::StreamBufferManager::OnRegisteredBuffer(
166 size_t buffer_id,
167 int32_t result) {
168 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
169
170 if (!capturing_) {
171 return;
172 }
173 if (result) {
174 camera_device_delegate_->SetErrorState(
175 FROM_HERE, std::string("Failed to register buffer: ") +
176 std::string(strerror(result)));
177 return;
178 }
179 ProcessCaptureRequest(buffer_id);
180 }
181
182 void CameraDeviceDelegate::StreamBufferManager::ProcessCaptureRequest(
183 size_t buffer_id) {
184 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
185 DCHECK(stream_context_);
186
187 arc::mojom::Camera3StreamBufferPtr buffer =
188 arc::mojom::Camera3StreamBuffer::New();
189 buffer->stream_id = static_cast<uint64_t>(
190 arc::mojom::Camera3RequestTemplate::CAMERA3_TEMPLATE_PREVIEW);
191 buffer->buffer_id = buffer_id;
192 buffer->status = arc::mojom::Camera3BufferStatus::CAMERA3_BUFFER_STATUS_OK;
193
194 arc::mojom::Camera3CaptureRequestPtr request =
195 arc::mojom::Camera3CaptureRequest::New();
196 request->frame_number = frame_number_;
197 request->settings = stream_context_->request_settings.Clone();
198 request->output_buffers.push_back(std::move(buffer));
199
200 camera_device_delegate_->ProcessCaptureRequest(
201 std::move(request),
202 base::Bind(
203 &CameraDeviceDelegate::StreamBufferManager::OnProcessedCaptureRequest,
204 this));
205 VLOG(2) << "Requested capture for frame " << frame_number_ << " with buffer "
206 << buffer_id;
207 frame_number_++;
208 // In case |frame_number_| wraps around, we start at 1 to avoid resetting
209 // |first_frame_shutter_time_|.
210 if (!frame_number_) {
211 frame_number_++;
212 }
213 }
214
215 void CameraDeviceDelegate::StreamBufferManager::OnProcessedCaptureRequest(
216 int32_t result) {
217 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
218
219 if (!capturing_) {
220 return;
221 }
222 if (result) {
223 camera_device_delegate_->SetErrorState(
224 FROM_HERE, std::string("Process capture request failed") +
225 std::string(strerror(result)));
226 return;
227 }
228 RegisterBuffer();
229 }
230
231 void CameraDeviceDelegate::StreamBufferManager::ProcessCaptureResult(
232 arc::mojom::Camera3CaptureResultPtr result) {
233 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
234
235 if (!capturing_) {
236 return;
237 }
238 uint32_t frame_number = result->frame_number;
239 // A new partial result may be created in either ProcessCaptureResult or
240 // Notify.
241 CaptureResult& partial_result = partial_results_[frame_number];
242 if (partial_results_.size() > stream_context_->stream->max_buffers) {
243 camera_device_delegate_->SetErrorState(
244 FROM_HERE,
245 "Received more capture results than the maximum number of buffers");
246 return;
247 }
248 if (result->output_buffers) {
249 if (result->output_buffers->size() != 1) {
250 camera_device_delegate_->SetErrorState(
251 FROM_HERE,
252 std::string("Incorrect number of output buffers received: ") +
253 std::to_string(result->output_buffers->size()));
254 return;
255 }
256 arc::mojom::Camera3StreamBufferPtr& stream_buffer =
257 result->output_buffers.value()[0];
258 VLOG(2) << "Received capture result for frame " << frame_number
259 << " stream_id: " << stream_buffer->stream_id;
260 // The camera HAL v3 API specifies that only one capture result can carry
261 // the result buffer for any given frame number.
262 if (!partial_result.buffer.is_null()) {
263 camera_device_delegate_->SetErrorState(
264 FROM_HERE,
265 std::string("Received multiple result buffers for frame ") +
266 std::to_string(frame_number));
267 return;
268 } else {
269 partial_result.buffer = std::move(stream_buffer);
270 }
271 }
272
273 // |result->partial_result| is set to 0 if the capture result contains only
274 // the result buffer handles and no result metadata.
275 if (result->partial_result) {
276 uint32_t result_id = result->partial_result;
277 if (result_id > partial_result_count_) {
278 camera_device_delegate_->SetErrorState(
279 FROM_HERE, std::string("Invalid partial_result id: ") +
280 std::to_string(result_id));
281 return;
282 }
283 if (partial_result.partial_metadata_received.find(result_id) !=
284 partial_result.partial_metadata_received.end()) {
285 camera_device_delegate_->SetErrorState(
286 FROM_HERE, std::string("Received duplicated partial metadata: ") +
287 std::to_string(result_id));
288 return;
289 }
290 partial_result.partial_metadata_received.insert(result_id);
291 MergeMetadata(&partial_result.metadata, result->result);
292 }
293
294 if (partial_result.partial_metadata_received.size() ==
295 partial_result_count_ &&
296 !partial_result.buffer.is_null()) {
297 // We can only submit the result buffer after we receive the shutter time.
298 if (partial_result.reference_time != base::TimeTicks()) {
299 SubmitCaptureResult(frame_number);
300 }
301 }
302 }
303
304 void CameraDeviceDelegate::StreamBufferManager::Notify(
305 arc::mojom::Camera3NotifyMsgPtr message) {
306 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
307
308 if (!capturing_) {
309 return;
310 }
311 if (message->type == arc::mojom::Camera3MsgType::CAMERA3_MSG_ERROR) {
312 uint32_t frame_number = message->message->get_error()->frame_number;
313 uint64_t error_stream_id = message->message->get_error()->error_stream_id;
314 arc::mojom::Camera3ErrorMsgCode error_code =
315 message->message->get_error()->error_code;
316 HandleNotifyError(frame_number, error_stream_id, error_code);
317 } else { // arc::mojom::Camera3MsgType::CAMERA3_MSG_SHUTTER
318 uint32_t frame_number = message->message->get_shutter()->frame_number;
319 uint64_t shutter_time = message->message->get_shutter()->timestamp;
320 // A new partial result may be created in either ProcessCaptureResult or
321 // Notify.
322 VLOG(2) << "Received shutter time for frame " << frame_number;
323 if (!shutter_time) {
324 camera_device_delegate_->SetErrorState(
325 FROM_HERE, std::string("Received invalid shutter time: ") +
326 std::to_string(shutter_time));
327 return;
328 }
329 CaptureResult& partial_result = partial_results_[frame_number];
330 if (partial_results_.size() > stream_context_->stream->max_buffers) {
331 camera_device_delegate_->SetErrorState(
332 FROM_HERE,
333 "Received more capture results than the maximum number of buffers");
334 return;
335 }
336 // Shutter timestamp is in ns.
337 base::TimeTicks reference_time =
338 base::TimeTicks::FromInternalValue(shutter_time / 1000);
339 partial_result.reference_time = reference_time;
340 if (!frame_number) {
341 // Record the shutter time of the first frame for calculating the
342 // timestamp.
343 first_frame_shutter_time_ = reference_time;
344 }
345 partial_result.timestamp = reference_time - first_frame_shutter_time_;
346 if (partial_result.partial_metadata_received.size() ==
347 partial_result_count_ &&
348 !partial_result.buffer.is_null()) {
349 SubmitCaptureResult(frame_number);
350 }
351 }
352 }
353
354 void CameraDeviceDelegate::StreamBufferManager::HandleNotifyError(
355 uint32_t frame_number,
356 uint64_t error_stream_id,
357 arc::mojom::Camera3ErrorMsgCode error_code) {
358 switch (error_code) {
359 case arc::mojom::Camera3ErrorMsgCode::CAMERA3_MSG_ERROR_DEVICE:
360 // Fatal error and no more frames will be produced by the device.
361 camera_device_delegate_->SetErrorState(FROM_HERE, "Fatal device error");
362 break;
363 case arc::mojom::Camera3ErrorMsgCode::CAMERA3_MSG_ERROR_REQUEST: {
364 // An error has occurred in processing the request; the request
365 // specified by |frame_number| has been dropped by the camera device.
366 // Subsequent requests are unaffected.
367 //
368 // The HAL will call ProcessCaptureResult with the buffers' state set to
369 // STATUS_ERROR. The content of the buffers will be dropped and the
370 // buffers will be reused in SubmitCaptureResult.
371 std::string warning_msg =
372 std::string("An error occurred while processing request for frame ") +
373 std::to_string(frame_number);
374 LOG(WARNING) << warning_msg;
375 camera_device_delegate_->LogToClient(warning_msg);
376 break;
377 }
378 case arc::mojom::Camera3ErrorMsgCode::CAMERA3_MSG_ERROR_RESULT: {
379 // An error has occurred in producing the output metadata buffer for a
380 // result; the output metadata will not be available for the frame
381 // specified by |frame_number|. Subsequent requests are unaffected.
382 std::string warning_msg = std::string(
383 "An error occurred while producing result "
384 "metadata for frame ") +
385 std::to_string(frame_number);
386 LOG(WARNING) << warning_msg;
387 camera_device_delegate_->LogToClient(warning_msg);
388 // The result metadata will not be complete so we don't need to wait for
389 // partial results on frame |frame_number|.
390 partial_results_[frame_number].partial_metadata_received.clear();
391 for (uint32_t i = 0; i < partial_result_count_; ++i) {
392 partial_results_[frame_number].partial_metadata_received.insert(i);
393 }
394 break;
395 }
396 case arc::mojom::Camera3ErrorMsgCode::CAMERA3_MSG_ERROR_BUFFER:
397 // An error has occurred in placing the output buffer into a stream for
398 // a request. |frame_number| specifies the request for which the buffer
399 // was dropped, and |error_stream_id| specifies the stream that dropped
400 // the buffer.
401 //
402 // The HAL will call ProcessCaptureResult with the buffer's state set to
403 // STATUS_ERROR. The content of the buffer will be dropped and the
404 // buffer will be reused in SubmitCaptureResult.
405 camera_device_delegate_->LogToClient(
406 std::string(
407 "An error occurred while filling output buffer of stream ") +
408 std::to_string(error_stream_id) + std::string(" in frame ") +
409 std::to_string(frame_number));
410 break;
411 default:
412 // To eliminate the warning for not handling CAMERA3_MSG_NUM_ERRORS
413 break;
414 }
415 }
416
417 void CameraDeviceDelegate::StreamBufferManager::SubmitCaptureResult(
418 uint32_t frame_number) {
419 DCHECK(ipc_task_runner_->BelongsToCurrentThread());
420
421 if (partial_results_.begin()->first != frame_number) {
422 camera_device_delegate_->SetErrorState(
423 FROM_HERE, std::string("Received frame is out-of-order; expect ") +
424 std::to_string(partial_results_.begin()->first) +
425 std::string(" but got ") + std::to_string(frame_number));
426 return;
427 }
428
429 VLOG(2) << "Submit capture result of frame " << frame_number;
430 CaptureResult& partial_result = partial_results_[frame_number];
431 DCHECK_EQ(partial_result.partial_metadata_received.size(),
432 partial_result_count_);
433 DCHECK(partial_result.buffer);
434 uint32_t buffer_id = partial_result.buffer->buffer_id;
435
436 // Wait on release fence before delivering the result buffer to client.
437 if (partial_result.buffer->release_fence.is_valid()) {
438 const int kSyncWaitTimeoutMs = 1000;
439 mojo::edk::ScopedPlatformHandle fence;
440 MojoResult result = mojo::edk::PassWrappedPlatformHandle(
441 partial_result.buffer->release_fence.release().value(), &fence);
442 if (result != MOJO_RESULT_OK) {
443 camera_device_delegate_->SetErrorState(
444 FROM_HERE, "Failed to unwrap release fence fd");
445 return;
446 }
447 if (!sync_wait(fence.get().handle, kSyncWaitTimeoutMs)) {
448 camera_device_delegate_->SetErrorState(
449 FROM_HERE, "Sync wait on release fence timed out");
450 return;
451 }
452 }
453
454 // Deliver the captured data to client and then re-queue the buffer.
455 if (partial_result.buffer->status !=
456 arc::mojom::Camera3BufferStatus::CAMERA3_BUFFER_STATUS_ERROR) {
457 const base::SharedMemory* shm_buffer =
458 stream_context_->buffers[buffer_id].get();
459 camera_device_delegate_->SubmitCapturedData(
460 reinterpret_cast<uint8_t*>(shm_buffer->memory()),
461 shm_buffer->mapped_size(), stream_context_->capture_format,
462 partial_result.reference_time, partial_result.timestamp);
463 }
464 stream_context_->free_buffers.push(buffer_id);
465 partial_results_.erase(frame_number);
466 RegisterBuffer();
467 }
468
469 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698