Issue 2837243002: Redo "dart2js: --fast-startup: use alias for 'this'"

Issue 2837243002: Redo "dart2js: --fast-startup: use alias for 'this'" (Closed)

Created:
3 years, 8 months ago by sra1

Modified:
3 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Redo "dart2js: --fast-startup: use alias for 'this'" Doesn't currently work since we can't use js.Names and regular parameters/variables in the same JavaScript scope. Long term - we should fix this (https://github.com/dart-lang/sdk/issues/29455) Short term, we could generate variable strings that are named after the fields and disambiguate them manually. BUG= Committed: https://github.com/dart-lang/sdk/commit/2c313f812531c5e03f3dd8df85564a2ec08f36c7

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -14 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart	View	1	1 chunk	+34 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/field_wierd_name_test.dart	View	1	1 chunk	+149 lines, -0 lines	0 comments	Download

Total messages: 3 (2 generated)

sra1

3 years, 8 months ago (2017-04-27 03:51:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2c313f812531c5e03f3dd8df85564a2ec08f36c7 (presubmit successful).