fix #29426, class type alias was missing checks

fix #29426, class type alias was missing checks

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/613881a4333ca01f517554f6e699094b8290f408

[Jennifer Messerly, 2017-04-24 21:41:02]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Jennifer Messerly, 2017-04-24 21:41:03]

https://codereview.chromium.org/2837173002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (left):

https://codereview.chromium.org/2837173002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:543:
_checkForExtendsDeferredClassInTypeAlias(node);
I also attempted to add tests for all the checks that were not present in this
code path.

https://codereview.chromium.org/2837173002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:703:
_checkForImplicitDynamicType(node.superclass);
done in _checkClassInheritance now

https://codereview.chromium.org/2837173002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2837173002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:474:
_checkClassInheritance(node, superclass, withClause, implementsClause);
... a bit of postmortem culture going on here :)

Rather than just fix the problem, take steps to make it less likely to happen in
the future. By factoring out a common method there's now a shared place for the
shared checks.

[Brian Wilkerson, 2017-04-24 21:56:47]

lgtm

[Jennifer Messerly, 2017-04-24 22:02:40]

Description was changed from

==========
fix #29426, class type alias was missing checks
==========

to

==========
fix #29426, class type alias was missing checks

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/613881a4333ca01f517554f6e699094b8290f408
==========

[Jennifer Messerly, 2017-04-24 22:02:41]

Committed patchset #1 (id:1) manually as
613881a4333ca01f517554f6e699094b8290f408 (presubmit successful).