Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_unittest.cc

Issue 2837163004: Make call sites of subresource_filter::GetActiveConfigurations const-correct. (Closed)
Patch Set: Addressed comments from pkalinnikov@. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/subresource_filter/core/browser/subresource_filter_features.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
diff --git a/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc b/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
index 86ba034c785ef6fbfc446d5c302bde6c63a3d95d..892fe09bd0e5a55d81fff03e8b651f2644361519 100644
--- a/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
+++ b/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
@@ -42,7 +42,7 @@ TEST(SubresourceFilterFeaturesTest, ActivationLevel) {
: base::FeatureList::OVERRIDE_USE_DEFAULT,
test_case.activation_level_param, kActivationScopeNoSites);
- auto active_configurations = GetActiveConfigurations();
+ const auto active_configurations = GetActiveConfigurations();
const Configuration& actual_configuration =
active_configurations->the_one_and_only();
EXPECT_EQ(test_case.expected_activation_level,
@@ -81,7 +81,7 @@ TEST(SubresourceFilterFeaturesTest, ActivationScope) {
: base::FeatureList::OVERRIDE_USE_DEFAULT,
kActivationLevelDisabled, test_case.activation_scope_param);
- auto active_configurations = GetActiveConfigurations();
+ const auto active_configurations = GetActiveConfigurations();
const Configuration& actual_configuration =
active_configurations->the_one_and_only();
EXPECT_EQ(ActivationLevel::DISABLED, actual_configuration.activation_level);
@@ -134,7 +134,7 @@ TEST(SubresourceFilterFeaturesTest, ActivationLevelAndScope) {
: base::FeatureList::OVERRIDE_USE_DEFAULT,
test_case.activation_level_param, test_case.activation_scope_param);
- auto active_configurations = GetActiveConfigurations();
+ const auto active_configurations = GetActiveConfigurations();
const Configuration& actual_configuration =
active_configurations->the_one_and_only();
EXPECT_EQ(test_case.expected_activation_level,
@@ -192,7 +192,7 @@ TEST(SubresourceFilterFeaturesTest, ActivationList) {
kActivationLevelDisabled, kActivationScopeNoSites,
test_case.activation_list_param);
- auto active_configurations = GetActiveConfigurations();
+ const auto active_configurations = GetActiveConfigurations();
const Configuration& actual_configuration =
active_configurations->the_one_and_only();
EXPECT_EQ(test_case.expected_activation_list,
@@ -231,7 +231,7 @@ TEST(SubresourceFilterFeaturesTest, PerfMeasurementRate) {
{{kPerformanceMeasurementRateParameterName,
test_case.perf_measurement_param}});
- auto active_configurations = GetActiveConfigurations();
+ const auto active_configurations = GetActiveConfigurations();
const Configuration& actual_configuration =
active_configurations->the_one_and_only();
EXPECT_EQ(test_case.expected_perf_measurement_rate,
@@ -267,7 +267,7 @@ TEST(SubresourceFilterFeaturesTest, SuppressNotifications) {
{{kSuppressNotificationsParameterName,
test_case.suppress_notifications_param}});
- auto active_configurations = GetActiveConfigurations();
+ const auto active_configurations = GetActiveConfigurations();
const Configuration& actual_configuration =
active_configurations->the_one_and_only();
EXPECT_EQ(test_case.expected_suppress_notifications_value,
@@ -303,7 +303,7 @@ TEST(SubresourceFilterFeaturesTest, WhitelistSiteOnReload) {
{{kWhitelistSiteOnReloadParameterName,
test_case.whitelist_site_on_reload_param}});
- auto active_configurations = GetActiveConfigurations();
+ const auto active_configurations = GetActiveConfigurations();
const Configuration& actual_configuration =
active_configurations->the_one_and_only();
EXPECT_EQ(test_case.expected_whitelist_site_on_reload_value,
« no previous file with comments | « components/subresource_filter/core/browser/subresource_filter_features.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698