components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc - Issue 2837163004: Make call sites of subresource_filter::GetActiveConfigurations const-correct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Issue 2837163004: Make call sites of subresource_filter::GetActiveConfigurations const-correct. (Closed)

Patch Set: Addressed comments from pkalinnikov@. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/subresource_filter_component_installer.cc ('k') | components/subresource_filter/core/browser/subresource_filter_features.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

index df3f8c171f7ec4aa6ac1288197854833ce5457fc..90c0cb1883d1e5745533ad1ee9340bd526de8d57 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

@@ -115,7 +115,7 @@ ContentSubresourceFilterDriverFactory::

content::NavigationHandle* navigation_handle) const {

const GURL& url(navigation_handle->GetURL());

- auto configurations = GetActiveConfigurations();

+ const auto configurations = GetActiveConfigurations();

if (configurations->the_one_and_only().activation_level ==

ActivationLevel::DISABLED)

return ActivationDecision::ACTIVATION_DISABLED;

@@ -189,7 +189,7 @@ void ContentSubresourceFilterDriverFactory::WillProcessResponse(

RecordRedirectChainMatchPattern();

- auto configurations = GetActiveConfigurations();

+ const auto configurations = GetActiveConfigurations();

if (configurations->the_one_and_only().should_whitelist_site_on_reload &&

NavigationIsPageReload(url, referrer, transition)) {

// Whitelist this host for the current as well as subsequent navigations.

@@ -215,7 +215,7 @@ void ContentSubresourceFilterDriverFactory::WillProcessResponse(

}

void ContentSubresourceFilterDriverFactory::OnFirstSubresourceLoadDisallowed() {

- auto configurations = GetActiveConfigurations();

+ const auto configurations = GetActiveConfigurations();

if (configurations->the_one_and_only().should_suppress_notifications)

return;