Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: components/subresource_filter/core/browser/subresource_filter_features.h

Issue 2837163004: Make call sites of subresource_filter::GetActiveConfigurations const-correct. (Closed)
Patch Set: Addressed comments from pkalinnikov@. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H _ 5 #ifndef COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H _
6 #define COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H _ 6 #define COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURES_H _
7 7
8 #include "base/feature_list.h" 8 #include "base/feature_list.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 std::string ruleset_flavor; 52 std::string ruleset_flavor;
53 53
54 // Whether to whitelist a site when a page loaded from that site is reloaded. 54 // Whether to whitelist a site when a page loaded from that site is reloaded.
55 bool should_whitelist_site_on_reload = false; 55 bool should_whitelist_site_on_reload = false;
56 }; 56 };
57 57
58 // TODO(engedy): Make this an actual list once all call sites are prepared to 58 // TODO(engedy): Make this an actual list once all call sites are prepared to
59 // handle multiple simultaneous configurations. 59 // handle multiple simultaneous configurations.
60 class ConfigurationList : public base::RefCountedThreadSafe<ConfigurationList> { 60 class ConfigurationList : public base::RefCountedThreadSafe<ConfigurationList> {
61 public: 61 public:
62 ConfigurationList(Configuration config); 62 explicit ConfigurationList(Configuration config);
63 63
64 const Configuration& the_one_and_only() const { return config_; } 64 const Configuration& the_one_and_only() const { return config_; }
65 65
66 private: 66 private:
67 friend class base::RefCountedThreadSafe<ConfigurationList>; 67 friend class base::RefCountedThreadSafe<ConfigurationList>;
68 ~ConfigurationList(); 68 ~ConfigurationList();
69 69
70 const Configuration config_; 70 const Configuration config_;
71 71
72 DISALLOW_COPY_AND_ASSIGN(ConfigurationList); 72 DISALLOW_COPY_AND_ASSIGN(ConfigurationList);
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 extern const char kPerformanceMeasurementRateParameterName[]; 116 extern const char kPerformanceMeasurementRateParameterName[];
117 117
118 extern const char kSuppressNotificationsParameterName[]; 118 extern const char kSuppressNotificationsParameterName[];
119 119
120 extern const char kWhitelistSiteOnReloadParameterName[]; 120 extern const char kWhitelistSiteOnReloadParameterName[];
121 121
122 } // namespace subresource_filter 122 } // namespace subresource_filter
123 123
124 #endif // COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURE S_H_ 124 #endif // COMPONENTS_SUBRESOURCE_FILTER_CORE_BROWSER_SUBRESOURCE_FILTER_FEATURE S_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698