Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Issue 2837163002: Fixed racey testShutdown test, where echoServer was throwing an exception after trying to write to … (Closed)

Created:
3 years, 8 months ago by bkonyi
Modified:
3 years, 7 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed racey testShutdown test, where echoServer was throwing an exception after trying to write to a client socket closed for reading. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/4ebaac3d29593c8f16220a9cf57a77a8e8535a97

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tests/standalone/io/raw_synchronous_socket_test.dart View 1 chunk +2 lines, -3 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
bkonyi
3 years, 8 months ago (2017-04-24 20:56:04 UTC) #2
zra
lgtm
3 years, 8 months ago (2017-04-24 21:19:01 UTC) #3
bkonyi
Committed patchset #1 (id:1) manually as 4ebaac3d29593c8f16220a9cf57a77a8e8535a97 (presubmit successful).
3 years, 8 months ago (2017-04-24 21:21:48 UTC) #5
siva
3 years, 7 months ago (2017-04-27 18:28:56 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2837163002/diff/1/tests/standalone/io/raw_syn...
File tests/standalone/io/raw_synchronous_socket_test.dart (right):

https://codereview.chromium.org/2837163002/diff/1/tests/standalone/io/raw_syn...
tests/standalone/io/raw_synchronous_socket_test.dart:395:
socket.shutdown(SocketDirection.RECEIVE);
Instead of deleting the write which is a good test to see if we are still able
to write after doing a READ shutdown, why not send some data which the echo
server recognizes and does not echo it back.

Powered by Google App Engine
This is Rietveld 408576698