Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 2837153003: Views/Harmony Remove references to ui/views/layout/layout_constants.h (Closed)
Patch Set: Fix build redness Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/create_application_shortcut_view.cc
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc
index f50d34712360514a03d38d2a7034cc5d4f1bbfa2..fd2698cf9e0623a4eead510075dccb2123b53362 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.cc
+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc
@@ -8,6 +8,7 @@
#include "base/bind_helpers.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
#include "chrome/common/pref_names.h"
#include "chrome/grit/generated_resources.h"
#include "components/constrained_window/constrained_window_views.h"
@@ -98,6 +99,8 @@ void CreateChromeApplicationShortcutView::InitControls() {
profile_->GetPrefs()->GetBoolean(prefs::kWebAppCreateInAppsMenu));
#endif
+ ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
+
// Layout controls
views::GridLayout* layout = views::GridLayout::CreatePanel(this);
@@ -108,7 +111,8 @@ void CreateChromeApplicationShortcutView::InitControls() {
static const int kTableColumnSetId = 1;
column_set = layout->AddColumnSet(kTableColumnSetId);
- column_set->AddPaddingColumn(0, views::kCheckboxIndent);
+ column_set->AddPaddingColumn(
+ 0, provider->GetDistanceMetric(DISTANCE_SUBSECTION_HORIZONTAL_INDENT));
column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL,
100.0f, views::GridLayout::USE_PREF, 0, 0);
@@ -119,14 +123,16 @@ void CreateChromeApplicationShortcutView::InitControls() {
layout->StartRow(0, kTableColumnSetId);
layout->AddView(desktop_check_box_);
+ const int vertical_spacing =
+ provider->GetDistanceMetric(DISTANCE_RELATED_CONTROL_VERTICAL_SMALL);
if (menu_check_box_ != nullptr) {
- layout->AddPaddingRow(0, views::kRelatedControlSmallVerticalSpacing);
+ layout->AddPaddingRow(0, vertical_spacing);
layout->StartRow(0, kTableColumnSetId);
layout->AddView(menu_check_box_);
}
if (quick_launch_check_box_ != nullptr) {
- layout->AddPaddingRow(0, views::kRelatedControlSmallVerticalSpacing);
+ layout->AddPaddingRow(0, vertical_spacing);
layout->StartRow(0, kTableColumnSetId);
layout->AddView(quick_launch_check_box_);
}

Powered by Google App Engine
This is Rietveld 408576698