Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 283713002: Add API to event_sender. (Closed)

Created:
6 years, 7 months ago by erikchen
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add API to content shell for trackpad scrolling for Blink layout tests. - Added APIs for trackpad scroll begin/change/end events. - Modified the API for momentum scroll begin to take additional parameters to specify the deltaX and deltaY. Added the function MouseMomentumBegin2 to accomplish this. This will be replaced by MouseMomentumBegin once the blink change is landed. BUG=330887 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271445

Patch Set 1 #

Patch Set 2 : clang-format #

Total comments: 4

Patch Set 3 : Remove unused args. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -22 lines) Patch
M content/shell/renderer/test_runner/event_sender.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 2 8 chunks +96 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
erikchen
This CL is a dependency for the Blink CL at https://codereview.chromium.org/282743002/
6 years, 7 months ago (2014-05-13 20:41:44 UTC) #1
Nico
Things spanning multiple CLs always should have a BUG=. Thanks so much for looking at ...
6 years, 7 months ago (2014-05-14 10:47:12 UTC) #2
erikchen
PTAL https://codereview.chromium.org/283713002/diff/20001/content/shell/renderer/test_runner/event_sender.h File content/shell/renderer/test_runner/event_sender.h (right): https://codereview.chromium.org/283713002/diff/20001/content/shell/renderer/test_runner/event_sender.h#newcode151 content/shell/renderer/test_runner/event_sender.h:151: void MouseMomentumBegin2(gin::Arguments* args); On 2014/05/14 10:47:12, Nico (traveling ...
6 years, 7 months ago (2014-05-14 17:29:54 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/283713002/diff/20001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/283713002/diff/20001/content/shell/renderer/test_runner/event_sender.cc#newcode373 content/shell/renderer/test_runner/event_sender.cc:373: void TrackpadScrollBegin(gin::Arguments* args); begin and end don't seem to ...
6 years, 7 months ago (2014-05-15 15:30:44 UTC) #4
erikchen
https://codereview.chromium.org/283713002/diff/20001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/283713002/diff/20001/content/shell/renderer/test_runner/event_sender.cc#newcode373 content/shell/renderer/test_runner/event_sender.cc:373: void TrackpadScrollBegin(gin::Arguments* args); On 2014/05/15 15:30:45, jochen wrote: > ...
6 years, 7 months ago (2014-05-15 16:23:03 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-19 13:30:22 UTC) #6
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 7 months ago (2014-05-19 17:30:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/283713002/40001
6 years, 7 months ago (2014-05-19 17:31:13 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 19:07:15 UTC) #9
Message was sent while issue was closed.
Change committed as 271445

Powered by Google App Engine
This is Rietveld 408576698