Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Connections.js

Issue 2837083003: DevTools: create test infrastructure so devtools drives the test (Closed)
Patch Set: all Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/Connections.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js b/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js
index 987f68a141e2f2545453ec5cb0b26f2b03a7b23c..b3fe94239235bf00a508ee712143664ae94d3c47 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js
@@ -211,6 +211,9 @@ SDK.StubConnection = class {
* @param {string} message
*/
_respondWithError(message) {
+ if (Host.isUnderTest())
dgozman 2017/06/19 22:55:52 Why this?
chenwilliam 2017/06/19 23:48:18 I accidentally ran unit tests w/ integration test
+ return;
+
var messageObject = JSON.parse(message);
var error = {
message: 'This is a stub connection, can\'t dispatch message.',

Powered by Google App Engine
This is Rietveld 408576698