Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/Main.js

Issue 2837083003: DevTools: create test infrastructure so devtools drives the test (Closed)
Patch Set: all Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/Main.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js b/third_party/WebKit/Source/devtools/front_end/main/Main.js
index f89d2f43be82d687b1e5666e5aab821aef9ff211..1f3e3e3ac959508ebef0223470619aa8dcc353ab 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js
@@ -149,7 +149,7 @@ Main.Main = class {
* @suppressGlobalPropertiesCheck
*/
_createAppUI() {
- console.time('Main._createAppUI');
+ Main.time('Main._createAppUI');
UI.viewManager = new UI.ViewManager();
@@ -218,7 +218,7 @@ Main.Main = class {
this._registerMessageSinkListener();
self.runtime.extension(Common.AppProvider).instance().then(this._showAppUI.bind(this));
- console.timeEnd('Main._createAppUI');
+ Main.timeEnd('Main._createAppUI');
}
/**
@@ -226,7 +226,7 @@ Main.Main = class {
* @suppressGlobalPropertiesCheck
*/
_showAppUI(appProvider) {
- console.time('Main._showAppUI');
+ Main.time('Main._showAppUI');
var app = /** @type {!Common.AppProvider} */ (appProvider).createApp();
// It is important to kick controller lifetime after apps are instantiated.
Components.dockController.initialize();
@@ -265,17 +265,17 @@ Main.Main = class {
// Allow UI cycles to repaint prior to creating connection.
setTimeout(this._initializeTarget.bind(this), 0);
- console.timeEnd('Main._showAppUI');
+ Main.timeEnd('Main._showAppUI');
}
_initializeTarget() {
- console.time('Main._initializeTarget');
+ Main.time('Main._initializeTarget');
SDK.targetManager.connectToMainTarget(webSocketConnectionLost);
InspectorFrontendHost.readyForTest();
// Asynchronously run the extensions.
setTimeout(this._lateInitialization.bind(this), 100);
- console.timeEnd('Main._initializeTarget');
+ Main.timeEnd('Main._initializeTarget');
function webSocketConnectionLost() {
if (!Main._disconnectedScreenWithReasonWasShown)
@@ -959,4 +959,22 @@ Main.ShowMetricsRulersSettingUI = class {
}
};
+/**
+ * @param {string} label
+ */
+Main.time = function(label) {
dgozman 2017/06/19 22:55:52 Use static function in Main class instead.
chenwilliam 2017/06/19 23:48:18 Done.
+ if (Host.isUnderTest())
+ return;
+ console.time(label);
+};
+
+/**
+ * @param {string} label
+ */
+Main.timeEnd = function(label) {
+ if (Host.isUnderTest())
+ return;
+ console.timeEnd(label);
+};
+
new Main.Main();

Powered by Google App Engine
This is Rietveld 408576698