third_party/WebKit/Source/devtools/front_end/integration_test_runner/module.json - Issue 2837083003: DevTools: create test infrastructure so devtools drives the test

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/integration_test_runner/module.json

Issue 2837083003: DevTools: create test infrastructure so devtools drives the test (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/devtools/front_end/integration_test_runner/ConsoleTestRunner.js ('K') | « third_party/WebKit/Source/devtools/front_end/integration_test_runner/IntegrationTestRunner.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | third_party/WebKit/Source/devtools/front_end/main/Timer.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "dependencies": [

	3 "test_runner",
	dgozman 2017/04/25 21:08:28 Why not merge this module into test_runner? Why not merge this module into test_runner? chenwilliam 2017/06/15 01:01:05 We can't run certain modules in test_runner (unit Show quoted text On 2017/04/25 21:08:28, dgozman wrote: > Why not merge this module into test_runner? We can't run certain modules in test_runner (unit tests). Joel has details (I forgot :o)
	4 "sdk"

	5 ],

	6 "test_dependencies": [
	chenwilliam 2017/04/25 01:09:07 I want test writers to control the lifetime of loa I want test writers to control the lifetime of loading modules, so I created this to keep the dependency preprocessor happy. dgozman 2017/04/25 21:08:28 Why should tests worry about modules lifetime? Show quoted text On 2017/04/25 01:09:07, chenwilliam wrote: > I want test writers to control the lifetime of loading modules, so I created > this to keep the dependency preprocessor happy. Why should tests worry about modules lifetime? chenwilliam 2017/06/15 01:01:05 I want to avoid loading all modules up-front to av Show quoted text On 2017/04/25 21:08:28, dgozman wrote: > On 2017/04/25 01:09:07, chenwilliam wrote: > > I want test writers to control the lifetime of loading modules, so I created > > this to keep the dependency preprocessor happy. > > Why should tests worry about modules lifetime? I want to avoid loading all modules up-front to avoid the startup cost. I don't have a concrete case - but I imagine someone might want a test where clicking on a panel properly loads it. If we eagerly load modules (e.g. text editor) in the case of console, we might miss some edge cases (e.g. console properly shows messages before text editor has loaded).
	7 "console",

	8 "console_model"

	9 ],

	10 "scripts": [

	11 "ConsoleTestRunner.js",

	12 "IntegrationTestRunner.js"

	13 ]

	14 }

OLD	NEW