Add colon to switch cases and default

Add colon to switch cases and default

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/17360ffa6da8684aa85bb598787418aaf2279e5b

[messick, 2017-04-24 20:56:15]

messick@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[messick, 2017-04-24 20:56:15]

I will be focused on declarations next.

[Brian Wilkerson, 2017-04-24 21:07:40]

lgtm

https://codereview.chromium.org/2837063003/diff/20001/pkg/analysis_server/lib...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(right):

https://codereview.chromium.org/2837063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:185:
node = newNode;
Given that 'node' is set to 'newNode' in two thirds of the cases, seems like
there's an opportunity for more clean-up here. Certainly not required for this
CL, though.

https://codereview.chromium.org/2837063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:783:
(catchClause) =>
Given that the method has been generalized, perhaps a more general parameter
name?

[scheglov, 2017-04-24 21:08:57]

lgtm

[messick, 2017-04-25 18:13:23]

I'll make changes to this code in the next CL, too.

https://codereview.chromium.org/2837063003/diff/20001/pkg/analysis_server/lib...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(right):

https://codereview.chromium.org/2837063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:185:
node = newNode;
On 2017/04/24 21:07:40, Brian Wilkerson wrote:
> Given that 'node' is set to 'newNode' in two thirds of the cases, seems like
> there's an opportunity for more clean-up here. Certainly not required for this
> CL, though.

Acknowledged.

https://codereview.chromium.org/2837063003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:783:
(catchClause) =>
On 2017/04/24 21:07:40, Brian Wilkerson wrote:
> Given that the method has been generalized, perhaps a more general parameter
> name?

Acknowledged.

[messick, 2017-04-25 18:14:02]

Description was changed from

==========
Add colon to switch cases and default
==========

to

==========
Add colon to switch cases and default

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/17360ffa6da8684aa85bb598787418aaf2279e5b
==========

[messick, 2017-04-25 18:14:03]

Committed patchset #2 (id:20001) manually as
17360ffa6da8684aa85bb598787418aaf2279e5b (presubmit successful).