views: remove arrow from extension install dialog's details section

views: remove arrow from extension install dialog's details section

The arrow is gone in the Harmony mocks. Since the arrow was the only
reason ExpandableContainerView needed a GridLayout to begin with,
this change also converts it to use a BoxLayout. This affects the look
of this dialog in non-Harmony mode.

BUG=712585

[Elly Fong-Jones, 2017-04-24 18:40:30]

Description was changed from

==========
views: remove arrow from extension install dialog's details section

The arrow is gone in the Harmony mocks. Since the arrow was the only
reason ExpandableContainerView needed a GridLayout to begin with,
this change also converts it to use a BoxLayout. This affects the look
of this dialog in non-Harmony mode.

BUG=712585
==========

to

==========
views: remove arrow from extension install dialog's details section

The arrow is gone in the Harmony mocks. Since the arrow was the only
reason ExpandableContainerView needed a GridLayout to begin with,
this change also converts it to use a BoxLayout. This affects the look
of this dialog in non-Harmony mode.

BUG=712585
==========

[Elly Fong-Jones, 2017-04-24 18:40:30]

ellyjones@chromium.org changed reviewers:
+ benwells@chromium.org

[Elly Fong-Jones, 2017-04-24 18:41:05]

benwells@: ptal? I'd rather remove the arrow from the non-Harmony version of
this dialog as well since it significantly simplifies the code, but I can put it
back if it's meant to still be there.

[benwells, 2017-04-25 21:52:36]

benwells@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[benwells, 2017-04-25 21:52:36]

I'm going to point this to Devlin as it is changing existing extensions ui.

[Devlin, 2017-04-25 22:11:50]

Can you add before/after screenshots, either here or to the bug?  Also, can we
get someone on the UI team to quickly stamp that it's okay to remove the chevron
outside of harmony?

https://codereview.chromium.org/2837043003/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/2837043003/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:696:
layout->set_main_axis_alignment(views::BoxLayout::MAIN_AXIS_ALIGNMENT_START);
This is the default, isn't it?

[Elly Fong-Jones, 2017-04-26 15:24:20]

On 2017/04/25 22:11:50, Devlin wrote:
> Can you add before/after screenshots, either here or to the bug?  Also, can we
> get someone on the UI team to quickly stamp that it's okay to remove the
chevron
> outside of harmony?

Attached to the bug.

>
https://codereview.chromium.org/2837043003/diff/1/chrome/browser/ui/views/ext...
> File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
> (right):
> 
>
https://codereview.chromium.org/2837043003/diff/1/chrome/browser/ui/views/ext...
> chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:696:
> layout->set_main_axis_alignment(views::BoxLayout::MAIN_AXIS_ALIGNMENT_START);
> This is the default, isn't it?

[Elly Fong-Jones, 2017-04-26 15:24:33]

https://codereview.chromium.org/2837043003/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/2837043003/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:696:
layout->set_main_axis_alignment(views::BoxLayout::MAIN_AXIS_ALIGNMENT_START);
On 2017/04/25 22:11:50, Devlin wrote:
> This is the default, isn't it?

So it is, well spotted.

[Devlin, 2017-04-26 15:54:24]

if UX signs off on this on the bug, lgtm

https://codereview.chromium.org/2837043003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/2837043003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:42: #include
"ui/gfx/paint_vector_icon.h"
nit: no longer needed

https://codereview.chromium.org/2837043003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:46: #include
"ui/views/controls/button/image_button.h"
nit: no longer needed

[Elly Fong-Jones, 2017-04-26 16:41:55]

https://codereview.chromium.org/2837043003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/2837043003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:42: #include
"ui/gfx/paint_vector_icon.h"
On 2017/04/26 15:54:23, Devlin wrote:
> nit: no longer needed

Done.

https://codereview.chromium.org/2837043003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:46: #include
"ui/views/controls/button/image_button.h"
On 2017/04/26 15:54:23, Devlin wrote:
> nit: no longer needed

Done.

[Elly Fong-Jones, 2017-04-26 16:42:00]

The CQ bit was checked by ellyjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 16:42:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 17:42:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 17:42:28]

Dry run: This issue passed the CQ dry run.