Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2837033003: Fix exception when parsing broken code (issue 29447) (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-24 17:19:47 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-24 17:20:33 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-04-24 17:23:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
70e0d725ea2417060d366330599ba4d06ff02a62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698