Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp

Issue 2837023005: Move MediaQuery classes off BlinkGC heap (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp b/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp
index 5f7d95f83bf47e1f88815cc639ffe9188749a0ab..adba3786c2fb30fb2bf55c005fc2cb8ece6e25d3 100644
--- a/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp
@@ -53,7 +53,7 @@ bool SizesAttributeParser::CalculateLengthInPixels(CSSParserTokenRange range,
}
bool SizesAttributeParser::MediaConditionMatches(
- MediaQuerySet* media_condition) {
+ const MediaQuerySet& media_condition) {
// A Media Condition cannot have a media type other then screen.
MediaQueryEvaluator media_query_evaluator(*media_values_);
return media_query_evaluator.Eval(media_condition);
@@ -80,9 +80,10 @@ bool SizesAttributeParser::Parse(CSSParserTokenRange range) {
if (!CalculateLengthInPixels(
range.MakeSubRange(length_token_start, length_token_end), length))
continue;
- MediaQuerySet* media_condition = MediaQueryParser::ParseMediaCondition(
- range.MakeSubRange(media_condition_start, length_token_start));
- if (!media_condition || !MediaConditionMatches(media_condition))
+ RefPtr<MediaQuerySet> media_condition =
+ MediaQueryParser::ParseMediaCondition(
+ range.MakeSubRange(media_condition_start, length_token_start));
+ if (!media_condition || !MediaConditionMatches(*media_condition))
continue;
length_ = length;
length_was_set_ = true;

Powered by Google App Engine
This is Rietveld 408576698