Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: third_party/WebKit/Source/core/css/StyleRule.cpp

Issue 2837023005: Move MediaQuery classes off BlinkGC heap (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/StyleRule.cpp
diff --git a/third_party/WebKit/Source/core/css/StyleRule.cpp b/third_party/WebKit/Source/core/css/StyleRule.cpp
index bcc1c054f2aa0e4066f08634134b1284e2dc05c6..152a70f2e4ad86e9ef788c3a90e879ae4eb0870b 100644
--- a/third_party/WebKit/Source/core/css/StyleRule.cpp
+++ b/third_party/WebKit/Source/core/css/StyleRule.cpp
@@ -353,7 +353,7 @@ StyleRuleCondition::StyleRuleCondition(const StyleRuleCondition& condition_rule)
: StyleRuleGroup(condition_rule),
condition_text_(condition_rule.condition_text_) {}
-StyleRuleMedia::StyleRuleMedia(MediaQuerySet* media,
+StyleRuleMedia::StyleRuleMedia(RefPtr<MediaQuerySet> media,
HeapVector<Member<StyleRuleBase>>& adopt_rules)
: StyleRuleCondition(kMedia, adopt_rules), media_queries_(media) {}
@@ -363,11 +363,6 @@ StyleRuleMedia::StyleRuleMedia(const StyleRuleMedia& media_rule)
media_queries_ = media_rule.media_queries_->Copy();
}
-DEFINE_TRACE_AFTER_DISPATCH(StyleRuleMedia) {
- visitor->Trace(media_queries_);
- StyleRuleCondition::TraceAfterDispatch(visitor);
-}
-
StyleRuleSupports::StyleRuleSupports(
const String& condition_text,
bool condition_is_supported,
@@ -375,6 +370,10 @@ StyleRuleSupports::StyleRuleSupports(
: StyleRuleCondition(kSupports, condition_text, adopt_rules),
condition_is_supported_(condition_is_supported) {}
+DEFINE_TRACE_AFTER_DISPATCH(StyleRuleMedia) {
+ StyleRuleCondition::TraceAfterDispatch(visitor);
+}
+
StyleRuleSupports::StyleRuleSupports(const StyleRuleSupports& supports_rule)
: StyleRuleCondition(supports_rule),
condition_is_supported_(supports_rule.condition_is_supported_) {}

Powered by Google App Engine
This is Rietveld 408576698