Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp

Issue 2837023005: Move MediaQuery classes off BlinkGC heap (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
diff --git a/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp b/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
index db02731c2373aa94b9377c1902e123ba9572c740..75372d2ff245d6af50d59866d7d1900a8a61cd09 100644
--- a/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
+++ b/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
@@ -139,11 +139,10 @@ TestCase g_print_test_cases[] = {
void TestMQEvaluator(TestCase* test_cases,
const MediaQueryEvaluator& media_query_evaluator) {
- Persistent<MediaQuerySet> query_set = nullptr;
+ RefPtr<MediaQuerySet> query_set = nullptr;
for (unsigned i = 0; test_cases[i].input; ++i) {
query_set = MediaQuerySet::Create(test_cases[i].input);
- EXPECT_EQ(test_cases[i].output,
- media_query_evaluator.Eval(query_set.Get()));
+ EXPECT_EQ(test_cases[i].output, media_query_evaluator.Eval(*query_set));
}
}
@@ -194,8 +193,8 @@ TEST(MediaQueryEvaluatorTest, DynamicNoView) {
page_holder.reset();
ASSERT_EQ(nullptr, frame->View());
MediaQueryEvaluator media_query_evaluator(frame);
- MediaQuerySet* query_set = MediaQuerySet::Create("foobar");
- EXPECT_FALSE(media_query_evaluator.Eval(query_set));
+ RefPtr<MediaQuerySet> query_set = MediaQuerySet::Create("foobar");
+ EXPECT_FALSE(media_query_evaluator.Eval(*query_set));
}
TEST(MediaQueryEvaluatorTest, CachedFloatViewport) {

Powered by Google App Engine
This is Rietveld 408576698