Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryEvaluator.h

Issue 2837023005: Move MediaQuery classes off BlinkGC heap (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/MediaQueryEvaluator.h
diff --git a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h b/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h
index 7fe8fe81bb83a2ef1f3d111724434860010a7d69..4d3060105cc4d648cfca78154123b128b21b48e4 100644
--- a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h
+++ b/third_party/WebKit/Source/core/css/MediaQueryEvaluator.h
@@ -41,7 +41,7 @@ class MediaQuerySet;
class MediaValues;
class MediaValuesInitialViewport;
-using MediaQueryResultList = HeapVector<Member<MediaQueryResult>>;
+using MediaQueryResultList = Vector<MediaQueryResult>;
// Class that evaluates css media queries as defined in
// CSS3 Module "Media Queries" (http://www.w3.org/TR/css3-mediaqueries/)
@@ -83,17 +83,17 @@ class CORE_EXPORT MediaQueryEvaluator final
bool MediaTypeMatch(const String& media_type_to_match) const;
// Evaluates a list of media queries.
- bool Eval(const MediaQuerySet*,
+ bool Eval(const MediaQuerySet&,
MediaQueryResultList* viewport_dependent = nullptr,
MediaQueryResultList* device_dependent = nullptr) const;
// Evaluates media query.
- bool Eval(const MediaQuery*,
+ bool Eval(const MediaQuery&,
MediaQueryResultList* viewport_dependent = nullptr,
MediaQueryResultList* device_dependent = nullptr) const;
// Evaluates media query subexpression, ie "and (media-feature: value)" part.
- bool Eval(const MediaQueryExp*) const;
+ bool Eval(const MediaQueryExp&) const;
DECLARE_TRACE();

Powered by Google App Engine
This is Rietveld 408576698