Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/WebKit/Source/core/css/CSSStyleSheet.cpp

Issue 2837023005: Move MediaQuery classes off BlinkGC heap (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp b/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
index 5e4232db9371b0baf0837631a44c2832b4343dc5..a55a179a98b6cf1d29d5dd4ae32750567a107d71 100644
--- a/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
+++ b/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
@@ -205,7 +205,7 @@ void CSSStyleSheet::setDisabled(bool disabled) {
DidMutate();
}
-void CSSStyleSheet::SetMediaQueries(MediaQuerySet* media_queries) {
+void CSSStyleSheet::SetMediaQueries(PassRefPtr<MediaQuerySet> media_queries) {
media_queries_ = media_queries;
if (media_cssom_wrapper_ && media_queries_)
media_cssom_wrapper_->Reattach(media_queries_.Get());
@@ -217,7 +217,7 @@ bool CSSStyleSheet::MatchesMediaQueries(const MediaQueryEvaluator& evaluator) {
if (!media_queries_)
return true;
- return evaluator.Eval(media_queries_,
+ return evaluator.Eval(*media_queries_,
&viewport_dependent_media_query_results_,
&device_dependent_media_query_results_);
}
@@ -442,9 +442,6 @@ void CSSStyleSheet::SetText(const String& text) {
DEFINE_TRACE(CSSStyleSheet) {
visitor->Trace(contents_);
- visitor->Trace(media_queries_);
- visitor->Trace(viewport_dependent_media_query_results_);
- visitor->Trace(device_dependent_media_query_results_);
visitor->Trace(owner_node_);
visitor->Trace(owner_rule_);
visitor->Trace(media_cssom_wrapper_);

Powered by Google App Engine
This is Rietveld 408576698