Issue 2837012: Update the default thumbnail icon to be the size that render_view.cc expects....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2837012: Update the default thumbnail icon to be the size that render_view.cc expects.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Stephen White

Modified:
4 years ago

Reviewers:
Glen Murphy

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update the default thumbnail icon to be the size that render_view.cc expects. (These are my best mspaint skillz, so Glen, feel free to send me something more aesthetic, or at least centered). BUG=none TEST=new tab UI tests (should go back into expected range) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50407

Patch Set 1 #

Patch Set 2 : '' #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	M	chrome/app/theme/default_thumbnail.png	View		Binary file		0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

More centered version attached. On Mon, Jun 21, 2010 at 3:52 PM, <senorblanco@chromium.org> wrote: > ...

4 years, 11 months ago (2010-06-21 22:57:34 UTC) #2

Glen Murphy

4 years, 11 months ago (2010-06-21 22:57:42 UTC) #3

LGTM with new resource.

On Mon, Jun 21, 2010 at 3:57 PM, Glen Murphy <glen@chromium.org> wrote:
> More centered version attached.
>
> On Mon, Jun 21, 2010 at 3:52 PM,  <senorblanco@chromium.org> wrote:
>> Reviewers: Glen Murphy,
>>
>> Description:
>> Update the default thumbnail icon to be the size that render_view.cc
>> expects.
>> (These are my best mspaint skillz, so Glen, feel free to send me something
>> more
>> aesthetic, or at least centered).
>>
>> BUG=none
>> TEST=new tab UI tests (should go back into expected range)
>>
>>
>> Please review this at http://codereview.chromium.org/2837012/show
>>
>> SVN Base: svn://chrome-svn/chrome/trunk/src/
>>
>> Affected files:
>>  M     chrome/app/theme/default_thumbnail.png
>>
>>
>> Index: chrome/app/theme/default_thumbnail.png
>> ===================================================================
>> Cannot display: file marked as a binary type.
>> svn:mime-type = image/png
>>
>>
>>
>

Expand Messages | Collapse Messages