Handle instantiation of native classes in closed_world2_test

tests/compiler/dart2js/kernel/closed_world2_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Partial test that the closed world computed from [WorldImpact]s derived from
 // kernel is equivalent to the original computed from resolution.
 library dart2js.kernel.closed_world2_test;
 
 import 'package:async_helper/async_helper.dart';
 import 'package:compiler/src/closure.dart';
@@ skipping 17 matching lines @@
 import 'package:compiler/src/js_backend/native_data.dart';
 import 'package:compiler/src/js_backend/impact_transformer.dart';
 import 'package:compiler/src/js_backend/interceptor_data.dart';
 import 'package:compiler/src/js_backend/lookup_map_analysis.dart';
 import 'package:compiler/src/js_backend/mirrors_analysis.dart';
 import 'package:compiler/src/js_backend/mirrors_data.dart';
 import 'package:compiler/src/js_backend/no_such_method_registry.dart';
 import 'package:compiler/src/js_backend/resolution_listener.dart';
 import 'package:compiler/src/js_backend/type_variable_handler.dart';
 import 'package:compiler/src/native/enqueue.dart';
+import 'package:compiler/src/native/resolver.dart';
 import 'package:compiler/src/kernel/element_map.dart';
 import 'package:compiler/src/options.dart';
 import 'package:compiler/src/universe/world_builder.dart';
 import 'package:compiler/src/universe/world_impact.dart';
 import 'package:compiler/src/world.dart';
+import 'package:expect/expect.dart';
 import '../memory_compiler.dart';
 import '../serialization/helper.dart';
 import '../serialization/model_test_helper.dart';
 import '../serialization/test_helper.dart';
 
 import 'closed_world_test.dart';
 import 'impact_test.dart';
 
 const SOURCE = const {
   'main.dart': '''
+import 'dart:html';
+
 main() {
   print('Hello World');
   ''.contains; // Trigger member closurization.
+  new Element.div();
 }
 '''
 };
 
 main(List<String> args) {
   Arguments arguments = new Arguments.from(args);
   Uri entryPoint;
   Map<String, String> memorySourceFiles;
   if (arguments.uri != null) {
     entryPoint = arguments.uri;
     memorySourceFiles = const <String, String>{};
   } else {
     entryPoint = Uri.parse('memory:main.dart');
     memorySourceFiles = SOURCE;
   }
 
   asyncTest(() async {
     enableDebugMode();
 
     print('---- analyze-only ------------------------------------------------');
     Compiler compiler1 = compilerFor(
         entryPoint: entryPoint,
         memorySourceFiles: memorySourceFiles,
         options: [Flags.analyzeOnly, Flags.enableAssertMessage]);
     ElementResolutionWorldBuilder.useInstantiationMap = true;
     compiler1.resolution.retainCachesForTesting = true;
     await compiler1.run(entryPoint);
+    Expect.isFalse(compiler1.compilationFailed);
     ResolutionEnqueuer enqueuer1 = compiler1.enqueuer.resolution;
     BackendUsage backendUsage1 = compiler1.backend.backendUsage;
     ClosedWorld closedWorld1 = compiler1.resolutionWorldBuilder.closeWorld();
 
     print('---- analyze-all -------------------------------------------------');
     Compiler compiler = compilerFor(
         entryPoint: entryPoint,
         memorySourceFiles: memorySourceFiles,
         options: [
           Flags.analyzeAll,
           Flags.useKernel,
           Flags.enableAssertMessage
         ]);
     await compiler.run(entryPoint);
     compiler.resolutionWorldBuilder.closeWorld();
 
     print('---- closed world from kernel ------------------------------------');
     KernelToElementMap elementMap = new KernelToElementMap(compiler.reporter);
     elementMap.addProgram(compiler.backend.kernelTask.program);
     KernelEquivalence equivalence = new KernelEquivalence(elementMap);
     NativeBasicData nativeBasicData = computeNativeBasicData(elementMap);
     checkNativeBasicData(
-        compiler.backend.nativeBasicData, nativeBasicData, equivalence);
+        compiler1.backend.nativeBasicData, nativeBasicData, equivalence);
     List list = createKernelResolutionEnqueuerListener(
         compiler.options,
         compiler.reporter,
         compiler.deferredLoadTask,
         elementMap,
         nativeBasicData);
     ResolutionEnqueuerListener resolutionEnqueuerListener = list[0];
     BackendUsageBuilder backendUsageBuilder2 = list[1];
     ImpactTransformer impactTransformer = list[2];
+
     ResolutionEnqueuer enqueuer2 = new ResolutionEnqueuer(
         compiler.enqueuer,
         compiler.options,
         compiler.reporter,
         const TreeShakingEnqueuerStrategy(),
         resolutionEnqueuerListener,
         new KernelResolutionWorldBuilder(
             elementMap, nativeBasicData, const OpenWorldStrategy()),
         new KernelWorkItemBuilder(elementMap, impactTransformer),
         'enqueuer from kelements');
@@ skipping 33 matching lines @@
   LookupMapResolutionAnalysis lookupMapResolutionAnalysis =
       new LookupMapResolutionAnalysis(reporter, elementEnvironment);
 
   InterceptorDataBuilder interceptorDataBuilder =
       new InterceptorDataBuilderImpl(
           nativeBasicData, elementEnvironment, commonElements);
   BackendUsageBuilder backendUsageBuilder =
       new BackendUsageBuilderImpl(commonElements);
   NoSuchMethodRegistry noSuchMethodRegistry = new NoSuchMethodRegistry(
       commonElements, new KernelNoSuchMethodResolver(elementMap));
+  NativeClassResolver nativeClassResolver = new NativeClassResolverImpl(

[Siggi Cherem (dart-lang), 2017/04/25 19:45:53]

should we start using the strategy here?

[Johnni Winther, 2017/04/26 07:40:19]

Yes.

+      elementEnvironment, commonElements, nativeBasicData);
   NativeResolutionEnqueuer nativeResolutionEnqueuer =
       new NativeResolutionEnqueuer(options, elementEnvironment, commonElements,
-          backendUsageBuilder, new KernelNativeClassResolver(elementMap));
+          backendUsageBuilder, nativeClassResolver);
 
   ResolutionEnqueuerListener listener = new ResolutionEnqueuerListener(
       options,
       elementEnvironment,
       commonElements,
       impacts,
       nativeBasicData,
       interceptorDataBuilder,
       backendUsageBuilder,
       rtiNeedBuilder,
@@ skipping 200 matching lines @@
       usage2.isInvokeOnUsed);
   check(usage1, usage2, 'isRuntimeTypeUsed', usage1.isRuntimeTypeUsed,
       usage2.isRuntimeTypeUsed);
   check(usage1, usage2, 'isIsolateInUse', usage1.isIsolateInUse,
       usage2.isIsolateInUse);
   check(usage1, usage2, 'isFunctionApplyUsed', usage1.isFunctionApplyUsed,
       usage2.isFunctionApplyUsed);
   check(usage1, usage2, 'isNoSuchMethodUsed', usage1.isNoSuchMethodUsed,
       usage2.isNoSuchMethodUsed);
 }