extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc - Issue 2836973002: Enable find-in-page across GuestViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Issue 2836973002: Enable find-in-page across GuestViews. (Closed)

Patch Set: Fixes after revert. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | pdf/pdfium/pdfium_engine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

index 44793e92fbc282c4edbcd40664007f3c2154ebd3..ccc6b749805c3d30856ae69395ec7407103844ba 100644

--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

@@ -195,10 +195,6 @@ void MimeHandlerViewGuest::DidInitialize(

ExtensionsAPIClient::Get()->AttachWebContentsHelpers(web_contents());

}

-bool MimeHandlerViewGuest::ShouldHandleFindRequestsForEmbedder() const {

- return is_full_page_plugin();

bool MimeHandlerViewGuest::ZoomPropagatesFromEmbedderToGuest() const {

return false;

}