Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2836953002: Minor clean-up and bug fix (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_locator.dart View 1 chunk +8 lines, -2 lines 2 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 8 months ago (2017-04-24 15:03:21 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2836953002/diff/1/pkg/analysis_server/lib/src/plugin/plugin_locator.dart File pkg/analysis_server/lib/src/plugin/plugin_locator.dart (right): https://codereview.chromium.org/2836953002/diff/1/pkg/analysis_server/lib/src/plugin/plugin_locator.dart#newcode61 pkg/analysis_server/lib/src/plugin/plugin_locator.dart:61: * exists, the it is returned. /the/then/s
3 years, 8 months ago (2017-04-24 15:33:55 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2836953002/diff/1/pkg/analysis_server/lib/src/plugin/plugin_locator.dart File pkg/analysis_server/lib/src/plugin/plugin_locator.dart (right): https://codereview.chromium.org/2836953002/diff/1/pkg/analysis_server/lib/src/plugin/plugin_locator.dart#newcode61 pkg/analysis_server/lib/src/plugin/plugin_locator.dart:61: * exists, the it is returned. Done
3 years, 8 months ago (2017-04-24 15:48:52 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-04-24 15:49:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a81dac8288a4626794e83671c27c0be5b32cfb10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698