Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2836873005: Add support for unlinked summary inputs through --build-summary-unlinked-input (Closed)

Created:
3 years, 8 months ago by jakemac
Modified:
3 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for unlinked summary inputs through --build-summary-unlinked-input BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/466d951c25daed2c9c1ce05eef93694ed128ed0c

Patch Set 1 #

Total comments: 3

Patch Set 2 : code review update #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -10 lines) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 2 4 chunks +41 lines, -7 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 1 2 4 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jakemac
3 years, 8 months ago (2017-04-25 17:59:16 UTC) #2
jakemac
https://codereview.chromium.org/2836873005/diff/1/pkg/analyzer_cli/lib/src/build_mode.dart File pkg/analyzer_cli/lib/src/build_mode.dart (right): https://codereview.chromium.org/2836873005/diff/1/pkg/analyzer_cli/lib/src/build_mode.dart#newcode280 pkg/analyzer_cli/lib/src/build_mode.dart:280: if (bundle.linkedLibraryUris.isEmpty && I am not sure if this ...
3 years, 8 months ago (2017-04-25 17:59:58 UTC) #3
Paul Berry
lgtm https://codereview.chromium.org/2836873005/diff/1/pkg/analyzer_cli/lib/src/build_mode.dart File pkg/analyzer_cli/lib/src/build_mode.dart (right): https://codereview.chromium.org/2836873005/diff/1/pkg/analyzer_cli/lib/src/build_mode.dart#newcode220 pkg/analyzer_cli/lib/src/build_mode.dart:220: bundle.unlinkedUnitUris.where((uri) => !uri.startsWith('dart:'))); Why is `!uri.startsWith('dart:')` necessary? It ...
3 years, 8 months ago (2017-04-26 15:28:31 UTC) #4
jakemac
https://codereview.chromium.org/2836873005/diff/1/pkg/analyzer_cli/lib/src/build_mode.dart File pkg/analyzer_cli/lib/src/build_mode.dart (right): https://codereview.chromium.org/2836873005/diff/1/pkg/analyzer_cli/lib/src/build_mode.dart#newcode220 pkg/analyzer_cli/lib/src/build_mode.dart:220: bundle.unlinkedUnitUris.where((uri) => !uri.startsWith('dart:'))); On 2017/04/26 15:28:31, Paul Berry wrote: ...
3 years, 8 months ago (2017-04-26 16:06:09 UTC) #5
jakemac
3 years, 8 months ago (2017-04-26 16:11:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
466d951c25daed2c9c1ce05eef93694ed128ed0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698