Update different JumpList categories on demand

chrome/browser/win/jumplist.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WIN_JUMPLIST_H_
 #define CHROME_BROWSER_WIN_JUMPLIST_H_
 
 #include <stddef.h>
 
 #include <list>
@@ skipping 66 matching lines @@
     typedef std::pair<std::string, scoped_refptr<ShellLinkItem> > URLPair;
     std::list<URLPair> icon_urls_;
 
     // Items in the "Most Visited" category of the application JumpList,
     // protected by the list_lock_.
     ShellLinkItemList most_visited_pages_;
 
     // Items in the "Recently Closed" category of the application JumpList,
     // protected by the list_lock_.
     ShellLinkItemList recently_closed_pages_;
+
+    // A boolean flag indicating if "Most Visited" category of the JumpList
+    // has new updates therefore its icons need to be updated.
+    bool most_visited_pages_have_updates_;
+
+    // A boolean flag indicating if "Recently Closed" category of the JumpList
+    // has new updates therefore its icons need to be updated.
+    bool recently_closed_pages_have_updates_;
   };
 
   // Observer callback for TabRestoreService::Observer to notify when a tab is
   // added or removed.
   void TabRestoreServiceChanged(sessions::TabRestoreService* service) override;
 
   // Observer callback to notice when our associated TabRestoreService
   // is destroyed.
   void TabRestoreServiceDestroyed(
       sessions::TabRestoreService* service) override;
@@ skipping 11 matching lines @@
 
   // Returns true if the custom JumpList is enabled.
   // The custom jumplist works only on Windows 7 and above.
   static bool Enabled();
 
  private:
   friend JumpListFactory;
   explicit JumpList(Profile* profile);  // Use JumpListFactory instead
   ~JumpList() override;
 
-  // Creates a ShellLinkItem object from a tab (or a window) and add it to the
-  // given list.
   // These functions are copied from the RecentlyClosedTabsHandler class for
   // compatibility with the new-tab page.
+  // AddTab creates a ShellLinkItem object from a tab and add it to |data|.

[grt (UTC plus 2), 2017/04/27 09:05:25]

better yet:
  // Adds a new ShellLinkItem for |tab| to |data| provided that doing so will
not exceed |max_items|.

similar for AddWindow below

[grt (UTC plus 2), 2017/04/27 09:05:25]

nit: add -> adds

[grt (UTC plus 2), 2017/04/27 09:05:25]

nit: "Creates a ShellLinkItem..."

[chengx, 2017/04/27 17:21:11]

Done.

[chengx, 2017/04/27 17:21:11]

Done.

[chengx, 2017/04/27 17:21:11]

Done.

   bool AddTab(const sessions::TabRestoreService::Tab& tab,
-              ShellLinkItemList* list,
+              JumpListData* data,

[grt (UTC plus 2), 2017/04/27 09:05:25]

nit: out params must follow all in params
(https://google.github.io/styleguide/cppguide.html#Function_Parameter_Ordering).
please swap |data| and |max_items|. below, too.

[chengx, 2017/04/27 17:21:11]

Done. Thanks for pointing me to this.

               size_t max_items);
+  // Creates a ShellLinkItem object for each tab in the given |window| and add
+  // to |data|.
   void AddWindow(const sessions::TabRestoreService::Window& window,
-                 ShellLinkItemList* list,
+                 JumpListData* data,
                  size_t max_items);
 
   // Starts loading a favicon for each URL in |icon_urls_|.
   // This function sends a query to HistoryService.
   // When finishing loading all favicons, this function posts a task that
   // decompresses collected favicons and updates a JumpList.
   void StartLoadingFavicon();
 
   // A callback function for HistoryService that notify when a requested favicon
   // is available.
@@ skipping 42 matching lines @@
   // Timer for requesting delayed updates of the jumplist.
   base::OneShotTimer timer_;
 
   // Holds data that can be accessed from multiple threads.
   scoped_refptr<base::RefCountedData<JumpListData>> jumplist_data_;
 
   // Id of last favicon task. It's used to cancel current task if a new one
   // comes in before it finishes.
   base::CancelableTaskTracker::TaskId task_id_;
 
-  // A task runner running tasks to update the jumplist in JumpListIcons.
-  scoped_refptr<base::SingleThreadTaskRunner> update_jumplisticons_task_runner_;
+  // A task runner running tasks to update the JumpList.
+  scoped_refptr<base::SingleThreadTaskRunner> update_jumplist_task_runner_;
 
-  // A task runner running tasks to delete JumpListIconsOld directory.
-  scoped_refptr<base::SequencedTaskRunner> delete_jumplisticonsold_task_runner_;
+  // A task runner running tasks to delete JumpListIcons directory and
+  // JumpListIconsOld directory.
+  scoped_refptr<base::SequencedTaskRunner> delete_jumplisticons_task_runner_;
 
   // For callbacks may be run after destruction.
   base::WeakPtrFactory<JumpList> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(JumpList);
 };
 
 #endif  // CHROME_BROWSER_WIN_JUMPLIST_H_