Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: components/offline_pages/core/background/offliner_stub.h

Issue 2836863002: [Offline pages] Removing active_request_ from request coordinator (Closed)
Patch Set: Addressing code review feedback and fixing app status change bug Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/offliner_stub.h
diff --git a/components/offline_pages/core/background/offliner_stub.h b/components/offline_pages/core/background/offliner_stub.h
index 2d7f72a27dfbfd569907c0b6fafc76e499209dfc..d6ddc2486bd70b8db6d7e1883aca550713305580 100644
--- a/components/offline_pages/core/background/offliner_stub.h
+++ b/components/offline_pages/core/background/offliner_stub.h
@@ -5,6 +5,9 @@
#ifndef COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_OFFLINER_STUB_H_
#define COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_OFFLINER_STUB_H_
+#include <memory>
+
+#include "base/callback_forward.h"
#include "components/offline_pages/core/background/offliner.h"
namespace offline_pages {
@@ -20,7 +23,9 @@ class OfflinerStub : public Offliner {
const CompletionCallback& completion_callback,
const ProgressCallback& progress_callback) override;
- void Cancel(const CancelCallback& callback) override;
+ bool Cancel(const CancelCallback& callback) override;
+
+ bool HandleTimeout(int64_t request_id) override;
void disable_loading() { disable_loading_ = true; }
@@ -30,13 +35,11 @@ class OfflinerStub : public Offliner {
void reset_cancel_called() { cancel_called_ = false; }
- bool HandleTimeout(const SavePageRequest& request) override;
-
void enable_snapshot_on_last_retry() { snapshot_on_last_retry_ = true; }
private:
- CompletionCallback completion_callback_;
- ProgressCallback progress_callback_;
+ base::Closure completion_callback_;
+ std::unique_ptr<SavePageRequest> pending_request_;
bool disable_loading_;
bool enable_callback_;
bool cancel_called_;
« no previous file with comments | « components/offline_pages/core/background/offliner.h ('k') | components/offline_pages/core/background/offliner_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698