Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3006)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2836863002: [Offline pages] Removing active_request_ from request coordinator (Closed)
Patch Set: Addressing code review feedback and fixing app status change bug Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
index b6468181e2738088e01c93e0e494026555167caa..7e73c92ed4fc1d5f45adf27354c769ae9606c95c 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
@@ -207,7 +207,7 @@ class PrerenderingOfflinerTest : public testing::Test {
void OnCompletion(const SavePageRequest& request,
Offliner::RequestStatus status);
void OnProgress(const SavePageRequest& request, int64_t bytes);
- void OnCancel(int64_t offline_id);
+ void OnCancel(const SavePageRequest& request);
content::TestBrowserThreadBundle thread_bundle_;
TestingProfile profile_;
@@ -251,7 +251,7 @@ void PrerenderingOfflinerTest::OnCompletion(const SavePageRequest& request,
void PrerenderingOfflinerTest::OnProgress(const SavePageRequest& request,
int64_t bytes) {}
-void PrerenderingOfflinerTest::OnCancel(int64_t offline_id) {
+void PrerenderingOfflinerTest::OnCancel(const SavePageRequest& request) {
DCHECK(!cancel_callback_called_);
cancel_callback_called_ = true;
}
@@ -481,7 +481,7 @@ TEST_F(PrerenderingOfflinerTest, HandleTimeoutWithLowbarAndCompletedTriesMet) {
EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
progress_callback()));
loader()->set_is_lowbar_met(true);
- EXPECT_TRUE(offliner()->HandleTimeout(request));
+ EXPECT_TRUE(offliner()->HandleTimeout(kRequestId));
EXPECT_TRUE(loader()->start_snapshot_called());
PumpLoop();
// EXPECT_TRUE(SaveInProgress());
@@ -502,7 +502,7 @@ TEST_F(PrerenderingOfflinerTest,
EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
progress_callback()));
loader()->set_is_lowbar_met(true);
- EXPECT_TRUE(offliner()->HandleTimeout(request));
+ EXPECT_TRUE(offliner()->HandleTimeout(kRequestId));
EXPECT_TRUE(loader()->start_snapshot_called());
}
@@ -517,7 +517,7 @@ TEST_F(PrerenderingOfflinerTest,
EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
progress_callback()));
loader()->set_is_lowbar_met(false);
- EXPECT_FALSE(offliner()->HandleTimeout(request));
+ EXPECT_FALSE(offliner()->HandleTimeout(kRequestId));
EXPECT_FALSE(loader()->start_snapshot_called());
}
@@ -532,7 +532,7 @@ TEST_F(PrerenderingOfflinerTest,
EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
progress_callback()));
loader()->set_is_lowbar_met(false);
- EXPECT_FALSE(offliner()->HandleTimeout(request));
+ EXPECT_FALSE(offliner()->HandleTimeout(kRequestId));
EXPECT_FALSE(loader()->start_snapshot_called());
}
@@ -546,7 +546,7 @@ TEST_F(PrerenderingOfflinerTest, HandleTimeoutWithLowbarAndStartedTriesMet) {
EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
progress_callback()));
loader()->set_is_lowbar_met(true);
- EXPECT_TRUE(offliner()->HandleTimeout(request));
+ EXPECT_TRUE(offliner()->HandleTimeout(kRequestId));
EXPECT_TRUE(loader()->start_snapshot_called());
}
@@ -559,7 +559,7 @@ TEST_F(PrerenderingOfflinerTest, DISABLED_HandleTimeoutWithOnlyLowbarMet) {
EXPECT_TRUE(offliner()->LoadAndSave(request, completion_callback(),
progress_callback()));
loader()->set_is_lowbar_met(true);
- EXPECT_FALSE(offliner()->HandleTimeout(request));
+ EXPECT_FALSE(offliner()->HandleTimeout(kRequestId));
EXPECT_FALSE(loader()->start_snapshot_called());
}
« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | components/offline_pages/core/background/offliner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698