Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2836863002: [Offline pages] Removing active_request_ from request coordinator (Closed)
Patch Set: Addressing code review feedback and fixing app status change bug Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index 02dd912eff4b631a93c9f83a57eec92c3b2d5410..e7a934e4053c5041841af364daf1eb6ff7dc77d1 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -37,8 +37,8 @@ class PrerenderingOffliner : public Offliner {
bool LoadAndSave(const SavePageRequest& request,
const CompletionCallback& completion_callback,
const ProgressCallback& progress_callback) override;
- void Cancel(const CancelCallback& callback) override;
- bool HandleTimeout(const SavePageRequest& request) override;
+ bool Cancel(const CancelCallback& callback) override;
+ bool HandleTimeout(int64_t request_id) override;
// Allows a loader to be injected for testing. This may only be done once
// and must be called before any of the Offliner interface methods are called.
@@ -80,8 +80,6 @@ class PrerenderingOffliner : public Offliner {
// Listener function for changes to application background/foreground state.
void OnApplicationStateChange(
base::android::ApplicationState application_state);
- void HandleApplicationStateChangeCancel(const SavePageRequest& request,
- int64_t offline_id);
// Not owned.
content::BrowserContext* browser_context_;

Powered by Google App Engine
This is Rietveld 408576698