Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5921)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.h

Issue 2836863002: [Offline pages] Removing active_request_ from request coordinator (Closed)
Patch Set: Addressing code review feedback and fixing app status change bug Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/background_loader_offliner.h
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.h b/chrome/browser/android/offline_pages/background_loader_offliner.h
index a09d611b19f145cddb1f969496dcb2a908ac2f34..8e51e30a26ed8387e6ac007f52f8cdbe82c30b3b 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.h
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.h
@@ -44,8 +44,8 @@ class BackgroundLoaderOffliner : public Offliner,
bool LoadAndSave(const SavePageRequest& request,
const CompletionCallback& completion_callback,
const ProgressCallback& progress_callback) override;
- void Cancel(const CancelCallback& callback) override;
- bool HandleTimeout(const SavePageRequest& request) override;
+ bool Cancel(const CancelCallback& callback) override;
+ bool HandleTimeout(int64_t request_id) override;
// WebContentsObserver implementation.
void DocumentAvailableInMainFrame() override;
@@ -77,8 +77,6 @@ class BackgroundLoaderOffliner : public Offliner,
// Called when application state has changed.
void OnApplicationStateChange(
base::android::ApplicationState application_state);
- void HandleApplicationStateChangeCancel(const SavePageRequest& request,
- int64_t offline_id);
// Called to remember at what time we started loading.
void MarkLoadStartTime();
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698