Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2836843006: Only start action mode if there is a selection (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
index 0a09e02ea4bef50d47500f3fdb303baffb3114d0..206765454cee9117d7da6f9efe7edb0acbadea53 100644
--- a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
@@ -226,7 +226,7 @@ public class SelectionPopupController extends ActionModeCallbackHelper {
public void showActionModeOrClearOnFailure() {
mPendingShowActionMode = false;
- if (!isActionModeSupported()) return;
+ if (!isActionModeSupported() || !mHasSelection) return;
Tima Vaisburd 2017/04/25 21:34:49 Do we ever create this ActinMode for insertion? At
// Just refresh the view if action mode already exists.
if (isActionModeValid()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698