(Sheriff created another revert)Revert of chromeos: Add CPU temperature reader

Revert of chromeos: Add CPU temperature reader (patchset #11 id:220001 of https://codereview.chromium.org/2823583002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 466858 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc0NWZhZDlmZTBmNjhhNzk1YTE5MWEzMmNiMDM4ZDg2NGJmYzJkYmYM

Original issue's description:
> chromeos: Add CPU temperature reader
> 
> Reads from hwmon in sysfs.
> 
> This does the same thing as ReadCPUTempInfo() in
> chrome/browser/chromeos/policy/device_status_collector.cc, but it is
> available to the rest of Chrome.
> 
> BUG=chromium:709102
> 
> Review-Url: https://codereview.chromium.org/2823583002
> Cr-Commit-Position: refs/heads/master@{#466858}
> Committed: https://chromium.googlesource.com/chromium/src/+/745fad9fe0f68a795a191a32cb038d864bfc2dbf

TBR=derat@chromium.org,stevenjb@chromium.org,sque@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:709102

[findit-for-me, 2017-04-25 02:29:57]

Created Revert of chromeos: Add CPU temperature reader

[findit-for-me, 2017-04-25 02:30:01]

findit-for-me@appspot.gserviceaccount.com changed reviewers:
+ alancutter@google.com, hcarmona@google.com, pkalinnikov@google.com,
pmonette@google.com

[findit-for-me, 2017-04-25 02:30:02]

Sheriffs:

Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
If it is a false positive, please close it.

Findit(https://goo.gl/kROfz5) identified the original CL as the culprit
for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Simon Que, 2017-04-25 02:42:07]

On 2017/04/25 02:30:02, findit-for-me wrote:
> Sheriffs:
> 
> Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> If it is a false positive, please close it.
> 
> Findit(https://goo.gl/kROfz5) identified the original CL as the culprit
> for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

I'm working on a fix, will have it in about 5 minutes.

[Simon Que, 2017-04-25 02:47:25]

On 2017/04/25 02:42:07, Simon Que wrote:
> On 2017/04/25 02:30:02, findit-for-me wrote:
> > Sheriffs:
> > 
> > Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> > If it is a false positive, please close it.
> > 
> > Findit(https://goo.gl/kROfz5) identified the original CL as the culprit
> > for failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> I'm working on a fix, will have it in about 5 minutes.

This CL should fix it: https://codereview.chromium.org/2835413002/

[eae, 2017-04-25 03:28:09]

On 2017/04/25 02:47:25, Simon Que wrote:
> On 2017/04/25 02:42:07, Simon Que wrote:
> > On 2017/04/25 02:30:02, findit-for-me wrote:
> > > Sheriffs:
> > > 
> > > Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> > > If it is a false positive, please close it.
> > > 
> > > Findit(https://goo.gl/kROfz5) identified the original CL as the culprit
> > > for failures in the build cycles as shown on:
> > >
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> > 
> > I'm working on a fix, will have it in about 5 minutes.
> 
> This CL should fix it: https://codereview.chromium.org/2835413002/

Tree has been closed for this over an hour. CQ+ ing revert.

[eae, 2017-04-25 03:28:14]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-04-25 03:28:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 03:28:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 03:28:47]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[yhirano, 2017-04-25 04:12:21]

Description was changed from

==========
Revert of chromeos: Add CPU temperature reader (patchset #11 id:220001 of
https://codereview.chromium.org/2823583002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 466858 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> chromeos: Add CPU temperature reader
> 
> Reads from hwmon in sysfs.
> 
> This does the same thing as ReadCPUTempInfo() in
> chrome/browser/chromeos/policy/device_status_collector.cc, but it is
> available to the rest of Chrome.
> 
> BUG=chromium:709102
> 
> Review-Url: https://codereview.chromium.org/2823583002
> Cr-Commit-Position: refs/heads/master@{#466858}
> Committed:
https://chromium.googlesource.com/chromium/src/+/745fad9fe0f68a795a191a32cb03...

TBR=derat@chromium.org,stevenjb@chromium.org,sque@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:709102
==========

to

==========
Revert of chromeos: Add CPU temperature reader (patchset #11 id:220001 of
https://codereview.chromium.org/2823583002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 466858 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> chromeos: Add CPU temperature reader
> 
> Reads from hwmon in sysfs.
> 
> This does the same thing as ReadCPUTempInfo() in
> chrome/browser/chromeos/policy/device_status_collector.cc, but it is
> available to the rest of Chrome.
> 
> BUG=chromium:709102
> 
> Review-Url: https://codereview.chromium.org/2823583002
> Cr-Commit-Position: refs/heads/master@{#466858}
> Committed:
https://chromium.googlesource.com/chromium/src/+/745fad9fe0f68a795a191a32cb03...

TBR=derat@chromium.org,stevenjb@chromium.org,sque@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:709102

TBR=sque@chromium.org
==========

[yhirano, 2017-04-25 04:12:38]

Description was changed from

==========
Revert of chromeos: Add CPU temperature reader (patchset #11 id:220001 of
https://codereview.chromium.org/2823583002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 466858 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> chromeos: Add CPU temperature reader
> 
> Reads from hwmon in sysfs.
> 
> This does the same thing as ReadCPUTempInfo() in
> chrome/browser/chromeos/policy/device_status_collector.cc, but it is
> available to the rest of Chrome.
> 
> BUG=chromium:709102
> 
> Review-Url: https://codereview.chromium.org/2823583002
> Cr-Commit-Position: refs/heads/master@{#466858}
> Committed:
https://chromium.googlesource.com/chromium/src/+/745fad9fe0f68a795a191a32cb03...

TBR=derat@chromium.org,stevenjb@chromium.org,sque@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:709102

TBR=sque@chromium.org
==========

to

==========
Revert of chromeos: Add CPU temperature reader (patchset #11 id:220001 of
https://codereview.chromium.org/2823583002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 466858 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> chromeos: Add CPU temperature reader
> 
> Reads from hwmon in sysfs.
> 
> This does the same thing as ReadCPUTempInfo() in
> chrome/browser/chromeos/policy/device_status_collector.cc, but it is
> available to the rest of Chrome.
> 
> BUG=chromium:709102
> 
> Review-Url: https://codereview.chromium.org/2823583002
> Cr-Commit-Position: refs/heads/master@{#466858}
> Committed:
https://chromium.googlesource.com/chromium/src/+/745fad9fe0f68a795a191a32cb03...

TBR=derat@chromium.org,stevenjb@chromium.org,sque@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:709102
==========

[yhirano, 2017-04-25 04:13:30]

On 2017/04/25 03:28:47, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet.
> CQ run can only be started once the patch has received an L-G-T-M from a full
> committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
> full super star committer.
> Committers are members of the group "project-chromium-committers".
> Note that this has nothing to do with OWNERS files.

Why is TBR ignored?

[yhirano, 2017-04-25 05:05:01]

On 2017/04/25 04:13:30, yhirano wrote:
> On 2017/04/25 03:28:47, commit-bot: I haz the power wrote:
> > No L-G-T-M from a valid reviewer yet.
> > CQ run can only be started once the patch has received an L-G-T-M from a
full
> > committer.
> > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_
a
> > full super star committer.
> > Committers are members of the group "project-chromium-committers".
> > Note that this has nothing to do with OWNERS files.
> 
> Why is TBR ignored?

I'm creating another revert change.

[stgao, 2017-04-26 17:14:40]

On 2017/04/25 04:13:30, yhirano wrote:
> On 2017/04/25 03:28:47, commit-bot: I haz the power wrote:
> > No L-G-T-M from a valid reviewer yet.
> > CQ run can only be started once the patch has received an L-G-T-M from a
full
> > committer.
> > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_
a
> > full super star committer.
> > Committers are members of the group "project-chromium-committers".
> > Note that this has nothing to do with OWNERS files.
> 
> Why is TBR ignored?

The findit app account has no committer permission, so a manual L-G-T-M from
sheriff is required.

It seems the message in comment #3 is not apparent enough.
Do you have suggestion on how to make it more apparent?