Index: net/tools/quic/end_to_end_test.cc |
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc |
index e06a9eda36db9f2d4eb9c59887a1967a13602c14..c6621adcdaf38daff03e8f9e1c1d45f73fd3fc6b 100644 |
--- a/net/tools/quic/end_to_end_test.cc |
+++ b/net/tools/quic/end_to_end_test.cc |
@@ -483,7 +483,7 @@ TEST_P(EndToEndTest, DISABLED_LargePostNoPacketLoss) { |
client_->client()->WaitForCryptoHandshakeConfirmed(); |
- // 1 Mb body. |
+ // 1 MB body. |
string body; |
GenerateBody(&body, 1024 * 1024); |
@@ -501,7 +501,7 @@ TEST_P(EndToEndTest, LargePostNoPacketLoss1sRTT) { |
client_->client()->WaitForCryptoHandshakeConfirmed(); |
- // 1 Mb body. |
+ // 100 KB body. |
string body; |
GenerateBody(&body, 100 * 1024); |
@@ -523,7 +523,7 @@ TEST_P(EndToEndTest, LargePostWithPacketLoss) { |
client_->client()->WaitForCryptoHandshakeConfirmed(); |
SetPacketLossPercentage(30); |
- // 10 Kb body. |
+ // 10 KB body. |
string body; |
GenerateBody(&body, 1024 * 10); |
@@ -532,42 +532,42 @@ TEST_P(EndToEndTest, LargePostWithPacketLoss) { |
request.AddBody(body, true); |
EXPECT_EQ(kFooResponseBody, client_->SendCustomSynchronousRequest(request)); |
+ VerifyCleanConnection(true); |
} |
-TEST_P(EndToEndTest, LargePostNoPacketLossWithDelayAndReordering) { |
+TEST_P(EndToEndTest, LargePostWithPacketLossAndBlockedSocket) { |
+ // Connect with lower fake packet loss than we'd like to test. Until |
+ // b/10126687 is fixed, losing handshake packets is pretty brutal. |
+ SetPacketLossPercentage(5); |
ASSERT_TRUE(Initialize()); |
+ // Wait for the server SHLO before upping the packet loss. |
client_->client()->WaitForCryptoHandshakeConfirmed(); |
- // Both of these must be called when the writer is not actively used. |
- SetPacketSendDelay(QuicTime::Delta::FromMilliseconds(2)); |
- SetReorderPercentage(30); |
+ SetPacketLossPercentage(10); |
+ client_writer_->set_fake_blocked_socket_percentage(10); |
- // 1 Mb body. |
+ // 10 KB body. |
string body; |
- GenerateBody(&body, 1024 * 1024); |
+ GenerateBody(&body, 1024 * 10); |
HTTPMessage request(HttpConstants::HTTP_1_1, |
HttpConstants::POST, "/foo"); |
request.AddBody(body, true); |
EXPECT_EQ(kFooResponseBody, client_->SendCustomSynchronousRequest(request)); |
- VerifyCleanConnection(true); |
} |
-TEST_P(EndToEndTest, LargePostWithPacketLossAndBlockedSocket) { |
- // Connect with lower fake packet loss than we'd like to test. Until |
- // b/10126687 is fixed, losing handshake packets is pretty brutal. |
- SetPacketLossPercentage(5); |
+TEST_P(EndToEndTest, LargePostNoPacketLossWithDelayAndReordering) { |
ASSERT_TRUE(Initialize()); |
- // Wait for the server SHLO before upping the packet loss. |
client_->client()->WaitForCryptoHandshakeConfirmed(); |
- SetPacketLossPercentage(10); |
- client_writer_->set_fake_blocked_socket_percentage(10); |
+ // Both of these must be called when the writer is not actively used. |
+ SetPacketSendDelay(QuicTime::Delta::FromMilliseconds(2)); |
+ SetReorderPercentage(30); |
- // 10 Kb body. |
+ // 1 MB body. |
string body; |
- GenerateBody(&body, 1024 * 10); |
+ GenerateBody(&body, 1024 * 1024); |
HTTPMessage request(HttpConstants::HTTP_1_1, |
HttpConstants::POST, "/foo"); |
@@ -662,14 +662,14 @@ TEST_P(EndToEndTest, LargePostFEC) { |
TEST_P(EndToEndTest, DISABLED_LargePostLargeBuffer) { |
ASSERT_TRUE(Initialize()); |
SetPacketSendDelay(QuicTime::Delta::FromMicroseconds(1)); |
- // 1Mbit per second with a 128k buffer from server to client. Wireless |
+ // 256KB per second with a 128k buffer from server to client. Wireless |
// clients commonly have larger buffers, but our max CWND is 200. |
server_writer_->set_max_bandwidth_and_buffer_size( |
QuicBandwidth::FromBytesPerSecond(256 * 1024), 128 * 1024); |
client_->client()->WaitForCryptoHandshakeConfirmed(); |
- // 1 Mb body. |
+ // 1 MB body. |
string body; |
GenerateBody(&body, 1024 * 1024); |
@@ -792,7 +792,7 @@ TEST_P(EndToEndTest, DISABLED_LimitCongestionWindowAndRTT) { |
// Now use the negotiated limits with packet loss. |
SetPacketLossPercentage(30); |
- // 10 Kb body. |
+ // 10 KB body. |
string body; |
GenerateBody(&body, 1024 * 10); |