Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2836813002: Move ScrollbarManager from core to platform and use as Scrollbar parent (Closed)

Created:
3 years, 8 months ago by joelhockey
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-api_chromium.org, blink-reviews-paint_chromium.org, dglazkov+blink, dshwang, jchaffraix+rendering, Navid Zolghadr, blink-reviews, blink-reviews-frames_chromium.org, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScrollbarManager from core to platform and use as Scrollbar parent BUG=637460 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -173 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 7 chunks +6 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 14 chunks +17 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/paint/ScrollbarManager.h View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/core/paint/ScrollbarManager.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/scroll/ScrollbarManager.h View 2 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/platform/scroll/ScrollbarManager.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerScrollClient.h View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2834573005 Patch 20001

Messages

Total messages: 1 (1 generated)
joelhockey
3 years, 8 months ago (2017-04-24 02:59:15 UTC) #1 
Description was changed from

==========
Move ScrollbarManager from core to platform and use as Scrollbar parent

BUG=637460
==========

to

==========
Move ScrollbarManager from core to platform and use as Scrollbar parent

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

Powered by Google App Engine
This is Rietveld 408576698