Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2836733002: dart2js: patch file support cleanup (Closed)

Created:
3 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 8 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: patch file support cleanup - removes hacky support for patching based on the emitter - adds generics to js_array to match the current sdk BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/94e3e33602f73c621dce4c87802a260f3ed083b6

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove js_array change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -233 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 2 chunks +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 4 chunks +20 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +8 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 3 chunks +13 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/annotations.dart View 1 chunk +2 lines, -13 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 3 chunks +11 lines, -31 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 3 chunks +0 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 3 chunks +2 lines, -74 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Siggi Cherem (dart-lang)
3 years, 8 months ago (2017-04-21 22:38:43 UTC) #3
Siggi Cherem (dart-lang)
as requested: I moved the js_array change to a separate CL
3 years, 8 months ago (2017-04-21 22:43:06 UTC) #4
sra1
lgtm https://codereview.chromium.org/2836733002/diff/20001/sdk/lib/_internal/js_runtime/lib/js_array.dart File sdk/lib/_internal/js_runtime/lib/js_array.dart (right): https://codereview.chromium.org/2836733002/diff/20001/sdk/lib/_internal/js_runtime/lib/js_array.dart#newcode227 sdk/lib/_internal/js_runtime/lib/js_array.dart:227: Iterable<T> expand<T>(Iterable<T> f(E element)) { Split this file ...
3 years, 8 months ago (2017-04-21 22:43:32 UTC) #5
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2836733002/diff/20001/sdk/lib/_internal/js_runtime/lib/js_array.dart File sdk/lib/_internal/js_runtime/lib/js_array.dart (right): https://codereview.chromium.org/2836733002/diff/20001/sdk/lib/_internal/js_runtime/lib/js_array.dart#newcode227 sdk/lib/_internal/js_runtime/lib/js_array.dart:227: Iterable<T> expand<T>(Iterable<T> f(E element)) { On 2017/04/21 22:43:32, sra1 ...
3 years, 8 months ago (2017-04-21 22:49:54 UTC) #6
Siggi Cherem (dart-lang)
3 years, 8 months ago (2017-04-21 22:51:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
94e3e33602f73c621dce4c87802a260f3ed083b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698