base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java - Issue 2836723002: [Android] Enable multidex for release builds of chrome_public_test_apk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java

Issue 2836723002: [Android] Enable multidex for release builds of chrome_public_test_apk. (Closed)

Patch Set: agrieve comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/multidex/ChromiumMultiDexInstaller.java ('k') | base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java

diff --git a/base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java b/base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java

index fcd60869866f239ecda1d7efc821c5434cb6e579..a48c4ab71301190bef89adf33a2a056832068600 100644

--- a/base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java

+++ b/base/test/android/javatests/src/org/chromium/base/test/BaseChromiumAndroidJUnitRunner.java

@@ -4,7 +4,8 @@

package org.chromium.base.test;

-import android.os.Bundle;

+import android.app.Application;

+import android.content.Context;

import android.support.test.runner.AndroidJUnitRunner;

import org.chromium.base.multidex.ChromiumMultiDexInstaller;

@@ -18,8 +19,11 @@ import org.chromium.base.multidex.ChromiumMultiDexInstaller;

public class BaseChromiumAndroidJUnitRunner extends AndroidJUnitRunner {

@Override

- public void onCreate(Bundle arguments) {

- ChromiumMultiDexInstaller.install(getTargetContext());

- super.onCreate(arguments);

+ public Application newApplication(ClassLoader cl, String className, Context context)

+ throws ClassNotFoundException, IllegalAccessException, InstantiationException {

+ ChromiumMultiDexInstaller.install(new BaseChromiumRunnerCommon.MultiDexContextWrapper(

+ getContext(), getTargetContext()));

+ BaseChromiumRunnerCommon.reorderDexPathElements(cl, getContext(), getTargetContext());

+ return super.newApplication(cl, className, context);

}