Oilpan: Prepare moving HTMLTemplateElement to oipan

Source/core/dom/TemplateContentDocumentFragment.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 15 matching lines @@
 
 #ifndef TemplateContentDocumentFragment_h
 #define TemplateContentDocumentFragment_h
 
 #include "core/dom/DocumentFragment.h"
 
 namespace WebCore {
 
 class TemplateContentDocumentFragment FINAL : public DocumentFragment {
 public:
-    static PassRefPtr<TemplateContentDocumentFragment> create(Document& document, Element* host)
+    static PassRefPtrWillBeRawPtr<TemplateContentDocumentFragment> create(Document& document, Element& host)

[Mads Ager (chromium), 2014/05/13 15:52:26]

Why was this changed to a reference; it is used as a pointer in all of this
code.

[haraken, 2014/05/13 15:54:54]

Because the pointer is guaranteed to be non 0. If the pointer is guaranteed to
be non 0, Blink prefers using a reference. (Nit: I'm not a fan of the rule
though.)

[keishi, 2014/05/13 16:16:21]

Yeah, it looked like this is always non null.

[Mads Ager (chromium), 2014/05/15 08:04:04]

I think this would make more sense if m_host was an Element& but it is not and
it will never be with oilpan. Therefore, the only thing this change does is
introduce code where you need to get a reference with a '*' operator and the
next thing you do it get a pointer using the '&' operator. So we are turning
something into a reference and then we are storing it as a pointer. I don't
think that makes sense. The only change here is that the code is harder to read
and write because you have to add a '*' and a '&' and the rest of the code is
unchanged and still uses a pointer.

     {
-        return adoptRef(new TemplateContentDocumentFragment(document, host));
+        return adoptRefWillBeRefCountedGarbageCollected(new TemplateContentDocumentFragment(document, host));
     }
 
     Element* host() const { return m_host; }
-    void clearHost() { m_host = 0; }
+    void clearHost() { m_host = nullptr; }

[haraken, 2014/05/13 15:53:30]

You can add #if !ENABLE(OILPAN) to this method.

[keishi, 2014/05/13 16:16:21]

Done.

+
+    virtual void trace(Visitor*) OVERRIDE;
 
 private:
-    TemplateContentDocumentFragment(Document& document, Element* host)
+    TemplateContentDocumentFragment(Document& document, Element& host)
         : DocumentFragment(&document, CreateDocumentFragment)
-        , m_host(host)
+        , m_host(&host)
     {
     }
 
     virtual bool isTemplateContent() const OVERRIDE { return true; }
 
-    Element* m_host;
+    RawPtrWillBeMember<Element> m_host;
 };
 
 } // namespace WebCore
 
 #endif // TemplateContentDocumentFragment_h